Repository navigation
fix(mcp): stop notification tasks during manager shutdown - #196
Merged
Merged
Conversation
Coven-Harness: Codex / GPT-6
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stop MCP notification tasks when their manager is dropped or explicitly shut down, including quiet streams and resource delivery blocked by a full channel.
Context
Changes
Arc<DashMap<...>>; existing in-repository call sites remain compatible. The protected engine CLI/environment/stream contract is unchanged.Validation
All Cargo commands used the stable toolchain with
CARGO_INCREMENTAL=0.git diff --checkcargo fmt --allcargo test -p claurst-mcp: 55 passedcargo check --workspace(no warnings)cargo clippy --workspace --all-targets -- -D warningscargo test --workspace: clean workspace-package rebuild, 2,132 passed, 7 ignored. An earlier shared-target run reused unrelated API/core test binaries and was discarded; workspace check, Clippy, and the full suite were rerun after cleaning all 12 local packages while preserving external dependencies.PR Readiness