fix(goals): guard continuation against replacement and pause races

[BunsDev]

Summary

Prevent a completed turn or automatic stop from mutating a replacement goal. Pause operations classify their outcome in one transaction, so a concurrent manual pause retains the correct stop reason.

Context

• Follow-up to feat(goals): add path-scoped continuation boundary #175, recovered from the saved goal worktree during the approved dirty-worktree closeout.
• Scope: core goal storage and query continuation; the separate continuation-lease draft remains archived separately.

Changes

• Pin the observed goal identity before recording progress and recheck it during terminal transitions.
• Return whether a pause actually changed state and preserve terminal-goal counters.
• Add deterministic replacement, pause/resume, and manual-pause race regressions.

Validation

All Cargo commands used the stable toolchain and a shared target directory.

• git diff --check
• cargo fmt --all
• cargo check --workspace (no warnings)
• cargo clippy --workspace --all-targets -- -D warnings
• CARGO_INCREMENTAL=0 cargo test --workspace: 2,141 passed, 7 ignored
• cargo test -p claurst-core goal: 41 passed
• cargo test -p claurst-query goal_loop: 15 passed
• Five race regressions failed before the production fix; independent spec and quality reviews passed.
• Initial full-suite compilation exhausted disk; after removing regenerable incremental cache, the complete rerun passed.
• Manual TUI checks: N/A, no TUI behavior or layout changes.

PR Readiness

• Diff is limited to three intended files.
• Generated files were not edited by hand.
• No user-facing documentation changes are needed for these internal race corrections.
• No secrets, credentials, local paths, or unrelated logs are included.
• Separate continuation-lease work remains outside this patch.

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated
docs	Ready	Preview	Oct 13, 2026 1:05pm UTC