Skip to content

fix(api): preserve keepalive liveness through provider streams - #192

Merged
BunsDev merged 1 commit into
mainfrom
fix/dirty-worktree-closeout
Oct 13, 2026
Merged

BunsDev merged 1 commit into
mainfrom
fix/dirty-worktree-closeout

Conversation

@BunsDev

@BunsDev BunsDev commented Oct 13, 2026

Copy link
Copy Markdown
Member

Summary

Preserve Anthropic keepalive pings through the provider adapter so a live, quiet stream does not hit the query stall timeout.

Context

Changes

  • Forward content-free Ping events to the consumer's existing deadline reset.
  • Ignore pings in accumulation and transcript publication.
  • Cover adapter propagation and quiet-stream completion with paused Tokio time.

Validation

Commands run from src-rust using rustup run stable (Rust 1.99) and an external target directory.

  • git diff --check
  • cargo fmt --all
  • cargo check --workspace
  • cargo clippy --workspace --all-targets -- -D warnings
  • cargo test --workspace: 2,130 passed; 7 ignored.
  • Targeted: cargo test -p claurst-api keepalive_ping_reaches failed before the fix, then passed.
  • Targeted: provider keepalive liveness, empty accumulator and no transcript ping regression passed.
  • Not run: live authenticated provider request; deterministic stream coverage exercises the changed behavior without network credentials.

PR Readiness

  • Diff is limited to the intended files.
  • Generated files were not edited by hand.
  • User-facing docs/help are not needed for this internal liveness fix.
  • No secrets, credentials, local paths, or unrelated logs are included.
  • Independent review found no production blockers; its test-timing suggestion was applied.

Complete the saved provider keepalive follow-up to fixes #165 and #166.
Forward pings to the stall deadline without adding transcript content.

Coven-Harness: Codex / GPT-6
@vercel

vercel Bot commented Oct 13, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
docs Ready Ready Preview Oct 13, 2026 12:48pm UTC

Request Review

@BunsDev
BunsDev merged commit 82b09e2 into main Oct 13, 2026
4 checks passed
@BunsDev
BunsDev deleted the fix/dirty-worktree-closeout branch October 13, 2026 13:44

This branch was successfully deployed

1 active deployment
Preview — 47d099bd Deployed Oct 13, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Agent stalls: model announces work, ends turn with end_turn and no tool calls — loop accepts it as done

1 participant