Repository navigation
release: retry stapler when Apple's ticket service drops the connection - #464
Merged
Merged
Conversation
Three macos-15-intel jobs failed on 2026-10-14 after notarization was Accepted and the image stapled: twice `xcrun stapler validate` in the smoke step, once `stapler staple` in the notarize step, each with NSURLErrorDomain -1005 "The network connection was lost" against api.apple-cloudkit.com. stapler exits 68 for that as well as for a missing ticket, so the step read a network blip as "no stapled ticket" and failed a release build whose image was fine (#461). The v0.0.5 tag run 38631627111 hit it in the staple step. Both steps now call stapler through a small retry (five attempts, 20 s apart); a genuine rejection still fails every attempt. The smoke error names the second possibility. Closes #461 Coven-Harness: Claude Code / claude-fable-5-1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Wraps
xcrun stapler stapleandxcrun stapler validatein a five-attempt retry (20 s apart) in both macOS steps ofrelease.yml: Notarize and staple the disk images and Smoke-test artifacts. The smoke step's error now names the second possibility ("or Apple's ticket service could not be reached").Why
Three
macos-15-inteljobs failed today after notarization was Accepted and the image stapled, each onNSURLErrorDomain -1005 "The network connection was lost"againstapi.apple-cloudkit.com:stapler validatestapler staple(the tag run; its re-run is in progress)staplerexits 68 for a dropped connection as well as for a missing ticket, so the step reported "no stapled notarization ticket" for an image that had one. A real rejection still fails all five attempts.Proof
vitest run src/release-workflow.test.ts: 13 passed (the test now requires the retry in both steps and forbids a barexcrun stapler validatein the smoke step).actionlint: nothing new. The step scripts stay bash 3.2 compatible (no arrays orlocal -n;local attemptonly).If the re-run of 38631627111 fails the same way, this lands first and v0.0.5 is published by dispatching
release.ymlfrommainwithtag=v0.0.5,dry_run=false, which runs main's workflow against the tagged tree (docs/releasing.md, the v0.0.2 precedent).Closes #461