Add Windows portable build workflow#503
Conversation
|
ывапр |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a1d62b1762
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| with: | ||
| node-version: 22 | ||
| cache: npm | ||
| cache-dependency-path: package-lock.json |
There was a problem hiding this comment.
This workflow runs in a repo where the only npm lockfile is opennow-stable/package-lock.json (git ls-tree confirms there is no root package-lock.json), but actions/setup-node resolves cache-dependency-path from the checked-out workspace rather than the later defaults.run directory; the setup-node README describes this input as the path to the dependency file, with subdirectory lockfiles supplied explicitly. On any manual run this step will fail before dependencies install, so use opennow-stable/package-lock.json as in the existing CI workflow.
Useful? React with 👍 / 👎.
| uses: actions/upload-artifact@v4 | ||
| with: | ||
| name: OpenNOW-windows-portable-x64 | ||
| path: dist-release/*portable-x64.exe |
There was a problem hiding this comment.
Because electron-builder is invoked from opennow-stable, its configured output directory (directories.output: "dist-release") produces opennow-stable/dist-release/...; however this uses: step is not affected by defaults.run.working-directory (GitHub documents that defaults.run applies to run steps), and upload-artifact resolves this relative path outside the app directory. With if-no-files-found: error, the build can succeed but the workflow will fail to publish the portable executable unless the path includes opennow-stable/.
Useful? React with 👍 / 👎.
|
i may be stupid, but there is a portable version already |
|
hmm there is already portable version i dont know what this have to do |
3 participants
Adds a manual GitHub Actions workflow to build the OpenNOW Electron app as a Windows portable executable on a Windows runner.