[MichaelN0815]

Summary

• Automatically focus the corresponding input field when opening one of the three system protocol filter popups.
• Use the same focus handling already implemented on other WebUI pages.
• Fixes Kein Fokus auf das Eingabefeld nach Öffnen des "Filter-PopUps" im Systemprotokoll OpenCCU#3150.

Testing

• Verified all three filter popups (date, time, name) on a real CCU.
• Confirmed that the input field receives keyboard focus immediately after opening the popup.
• git apply --check and git diff --check completed successfully.

Summary by CodeRabbit

• Usability
  • Clicking a system protocol date, time, or name filter button now focuses the corresponding text input.

[coderabbitai]

Important

• Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration

• Source mode: Auto
• Repository: Unavailable
• Branch: Unavailable
• File: No configuration file from this repository applied
• Commit: Unavailable
• Layers: defaults
• Review profile: CHILL
• Plan: Advanced
• Run ID: 463bfadf-32cf-4351-913a-ddf349f575d9

No actionable comments were generated in the recent review.

Recent review info

Run configuration

• Source mode: Auto
• Repository: Unavailable
• Branch: Unavailable
• File: No configuration file from this repository applied
• Commit: Unavailable
• Layers: defaults
• Review profile: CHILL
• Plan: Advanced
• Run ID: 873184a3-9fe4-4e2b-ae95-e32d5d57eb40

Commits

Reviewing files that changed from the base of the PR and between 62753fc and ab0c252.

Files selected for processing: 1

• src/webui/rega/www/pages/tabs/control/systemProtocol.htm

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

Walkthrough

The date, time, and name filter buttons in the system protocol now focus their corresponding text inputs when clicked.

Changes: System protocol filter focus

Layer / File(s)	Summary
Connect filter buttons to inputs src/webui/rega/www/pages/tabs/control/systemProtocol.htm	Clicking each date, time, or name filter button focuses its corresponding text input.

Estimated code review effort: 2 (Simple) | ~8 minutes

Change: Bug fix · Severity of issue fixed: Low

Suggested reviewers: jens-maus

Merge Risk: Minimal · previous review ab0c2

No actionable merge-blocking risk remains in the supplied change.

Pre-merge checks: 5

Check name	Status	Explanation
Description Check		Check skipped - CodeRabbit’s high-level summary is enabled.
Title check		The title "fix(webui): focus system protocol filter inputs" matches the change. The raw summary says clicking each system protocol date, time, or name filter button now focuses its corresponding text …
Linked Issues check		Issue [#3150] requires focus in the date, time, and name filter popups. systemProtocol.htm adds click handlers for btnFilterDate, btnFilterTime, and btnFilterName. Each handler focuses its mat…
Out of Scope Changes check		The reviewed change is limited to the three System Protocol filter focus handlers in src/webui/rega/www/pages/tabs/control/systemProtocol.htm. These handlers directly implement issue [#3150]. No unr…
Docstring Coverage		No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…

Full details: Title check

Explanation

The title "fix(webui): focus system protocol filter inputs" matches the change. The raw summary says clicking each system protocol date, time, or name filter button now focuses its corresponding text input in systemProtocol.htm. The objectives say the same and link it to issue #3150. The title names the main behavior and the affected area, and it uses a conventional type prefix. It is specific enough for a teammate scanning history.

Full details: Linked Issues check

Explanation

Issue [#3150] requires focus in the date, time, and name filter popups. systemProtocol.htm adds click handlers for btnFilterDate, btnFilterTime, and btnFilterName. Each handler focuses its matching input: ftDate, ftTime, or ftName. The supplied summary and reviewed file establish coverage of all three filters.

Full details: Out of Scope Changes check

Explanation

The reviewed change is limited to the three System Protocol filter focus handlers in src/webui/rega/www/pages/tabs/control/systemProtocol.htm. These handlers directly implement issue [#3150]. No unrelated change is shown.

Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

Finishing Touches

Generate unit tests (beta)

• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

• X
• Mastodon
• Reddit
• LinkedIn

[MichaelN0815]

@coderabbitai review

[coderabbitai]

Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.