Skip to content

Updates for the new IDE XRPWeb & new version numbers#98

Open
fgrossman wants to merge 15 commits into
mainfrom
fgrossman-work
Open

Updates for the new IDE XRPWeb & new version numbers#98
fgrossman wants to merge 15 commits into
mainfrom
fgrossman-work

Conversation

@fgrossman

Copy link
Copy Markdown
Collaborator

XRPWeb has a different protocol for the gamepad and dashboard. It now uses the XRP Puppet Protocol.
Plus a few other minor fixes.
Moved the version numbers into the 2.2 range.

Sends data via bluetooth for the dashboard.
XPP support added and switched over gamepad and dashboard to support the new protocol
Cleaned up the XPP code. Got rid of commands.
Puppet protocol and Dashboard added.
Added to have the puppet protocol work over USB serial as well as Bluetooth.
Try's to free servo 3&4 in case it is a new board
Allows the user to let the connection, be AUTO, BLE, or USB_STDIO
First call to the singleton
updated version number
Newer versions of micropython don't accept 03 for ctrl-c handler just 3.
Since XRPLib stays in memory not clearing the custom variables, meant they were not updated on the next run.
Give time for the pull_up to take place before a first call to get the value.
Comment thread XRPLib/dashboard.py
self._puppet.set_variable('$encoder.4', self.motor_four.get_position_counts())

# Current sensor data
#self._puppet.set_variable('$current.left', self.CurrLADC.read_u16())

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason the current reads are commented?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There was never an implementation for current. It can not just be read, there is a timing part to getting the current.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My question was more one of code cleanliness - if the plan is to add this functionality in a later pr since its less simple thats fine too

@KalticCodes KalticCodes left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good - I haven't done extensive testing (will approve once I do) as I'm just now getting back into working on this - do we have docs made for the XPP protocol? It might be useful to include updated examples as part of this change as well

@fgrossman

Copy link
Copy Markdown
Collaborator Author

https://github.com/Open-STEM/XPPClient
This is the documentation and some sample programs that use XPP. Also the Dashboard in the the new IDE and the Gamepad support use XPP now.
Latest copy of the new IDE is at https://xrp-code-d-u01.wpi.edu/

@fgrossman

Copy link
Copy Markdown
Collaborator Author

We want to get the current sensors implemented. I put in a feature request to get it implemented and a task to un comment in the dashboard once it is implemented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants