docs: correct news summary cron from daily to weekly in README - #91
Conversation
The Inngest function is weekly-news-summary (lib/inngest/functions.ts), triggered by cron
|
@kuishou68 is attempting to deploy a commit to the ravixalgorithm's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review. 📝 WalkthroughWalkthroughREADME.md now describes the news summary email as a weekly Kit broadcast sent every Monday at 9 AM. ChangesNews Summary Email Documentation
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~3 minutes Change: Other Suggested reviewers: Merge Risk: ⚪ Minimal · up to The README schedule and Kit broadcast description match the implemented workflow, and the remaining Nodemailer documentation is not contradictory. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Thanks @kuishou68 for the fix !!! |
What
The README describes the Inngest news-summary workflow as a daily cron (
0 12 * * *) sending per-user emails, but the implementation is different:lib/inngest/functions.tsdefinesweekly-news-summarywith trigger{ event: 'app/send.weekly.news', cron: '0 9 * * 1' }(every Monday at 9 AM), with a// Rename to Weeklycomment right above it.send-kit-broadcaststep), not a per-user email, and no daily0 12 * * *cron exists anywhere in the codebase.Change
Two README lines updated to match the code (Features -> "Email & automation" bullet, and the Inngest workflow list):
0 12 * * *-> Daily News Summary per user" -> "Cron0 9 * * 1-> Weekly News Summary (every Monday at 9 AM, Kit broadcast)"Verification
lib/inngest/functions.ts: the only news-summary function isweekly-news-summarywith cron0 9 * * 1; no0 12 * * *cron exists.Summary by CodeRabbit