set/apply/TUI: skip pseudo-batteries without charge control attributes - #13
Open
lucserre wants to merge 1 commit into
Open
set/apply/TUI: skip pseudo-batteries without charge control attributes#13lucserre wants to merge 1 commit into
lucserre wants to merge 1 commit into
Conversation
hidpp_battery_N and similar power_supply nodes report type=Battery but expose no charge_control_* files. ListBatteries() returns them, so set/apply/TUI attempted SysfsWriteInt on non-existent paths and aborted before/after writing the real battery (ENOENT), breaking persistence. Backends now return ErrNotChargeable from SetThresholds when the target battery lacks the attributes they would write (per-battery check instead of globally-derived capabilities), and the three call sites skip such batteries instead of failing. Fixed-path backends (Apple, Acer, Samsung, Sony, Huawei, Lenovo-ideapad, LG legacy) are unaffected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hidpp_battery_N and similar power_supply nodes report type=Battery but
expose no charge_control_* files. ListBatteries() returns them, so
set/apply/TUI attempted SysfsWriteInt on non-existent paths and aborted
before/after writing the real battery (ENOENT), breaking persistence.
Backends now return ErrNotChargeable from SetThresholds when the target
battery lacks the attributes they would write (per-battery check instead
of globally-derived capabilities), and the three call sites skip such
batteries instead of failing. Fixed-path backends (Apple, Acer, Samsung,
Sony, Huawei, Lenovo-ideapad, LG legacy) are unaffected.