Skip to content

fix: [SDK-5576] merge the test-send consent and message questions into one #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sherwinski merged 2 commits into from
Oct 22, 2026
Merged

fix: [SDK-5576] merge the test-send consent and message questions into one #79

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
255f6b9
fix: [SDK-5576] merge the test-send consent and message questions int…
sherwinski Oct 19, 2026
b5c7e27
fix: [SDK-5576] drop the free-text instruction from the custom-messag…
sherwinski Oct 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions skills/verify/SKILL.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,11 +148,17 @@ If the app wires `OneSignal.login(externalId)` (grep the wrapper for the call):

### Step 4 — Test send (real notification to the fresh subscription)

Send to ONLY the subscription from step 2 — never a broadcast — and only after it shows `notification_types >= 1` (the step 2 gate). **Ask before sending, as a structured question (safety contract §14):** this is a real, visible push to a real device and an action on the user's live OneSignal app — state the target subscription id and the App ID, and get an explicit yes first. Never send without it.
Send to ONLY the subscription from step 2 — never a broadcast — and only after it shows `notification_types >= 1` (the step 2 gate). **Ask before sending, as ONE structured question (safety contract §14):** this is a real, visible push to a real device and an action on the user's live OneSignal app. The question states the target subscription id and the App ID, and one answer gives both the consent and the message. Never send without the yes. Do not ask a yes/no question first and a message question second; the options below cover both.

**Pre-send heads-up (say it with the ask):** if the device is in **Focus/Do Not Disturb** — or browser/OS notifications are muted for the app/site — a successfully delivered push won't visibly appear. Have the user check now so a delivered send isn't misread as a failure.
Question: "Send a test push to subscription `<SUB_ID>` on app `<APP_ID>`? Before you answer, check that Focus or Do Not Disturb is off and that notifications are allowed for this app or site. A delivered push does not show while they are blocked."

**Ask for the message as a second question in the same tool call** (safety contract §14 batches pending questions into one call): "What message do you want to send?" with 2 options, "Use the default message (Recommended)" and "I'll type my own message". Text typed through the host's free-text field is the body; if the user picks the second option and types nothing, ask once more for the body. Use the answer as the notification body (`<BODY>` below). The default body is `Congrats on successfully setting up the OneSignal SDK`. The send happens from this session via the MCP or the REST API — never from code inside the user's app.
Choices, in this order:

- Send the default message (Recommended)
- Send my own message
- Do not send

The default body is `Congrats on successfully setting up the OneSignal SDK`. Text typed through the host's free-text field is the body; if the user picks the second option, ask once for the body only. "Do not send" is the decline: report `verify.sent fail deferred` (the checkpoint block below) and skip the send. Use the answer as the notification body (`<BODY>` below). The send happens from this session via the MCP or the REST API — never from code inside the user's app.

@abdulraqeeb33 abdulraqeeb33 Oct 22, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both hosts add a free-text "Other" to this question (§14), and this line makes typed text the body. With the yes/no question gone, anything typed there now sends: "wait, is this the prod app?" goes out as the push. §14a needs an explicit yes for a send. Suggest: treat typed text as a proposed body, quote it back, and send only after one confirm. A question or unclear text is not a yes.

@sherwinski sherwinski Oct 22, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a good callout but not sure if it's worth adjusting on right now without any data to support it. Users currently have an escape hatch via "Do not send" so I'm hesitant to add more user input prompts when feedback so far has asked for fewer.

@abdulraqeeb33 abdulraqeeb33 Oct 22, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair on prompt count. The fix doesn't need a new prompt on the paths this PR designs: per bf4df2e an option and free text are exclusive, so typed text only arrives when none of the three was picked, which is the case with no yes. "Do not send" doesn't catch that user, since they never pick it. Suggest replacing "Text typed through the host's free-text field is the body" with "Typed text is not a yes: answer it, then ask again." That costs a prompt only for someone who skips the options.


**The title is fixed:** every test push carries `headings: { "en": "Successful test via OneSignal plugin" }`. Do not offer to change it and do not accept an override — the user's message only sets the body. The title must never be absent: Huawei rejects a push without one, so a missing title is a silent blocker. **No brand voice on this push:** do not load or apply server-shipped brand or copy guidance to the test send (safety contract §14a). The title is fixed, and the body is the user's words or the default above.

Expand Down
Loading