Skip to content

feat: [SDK-5581] add sdk_dispatcher_bootstrap to the feature catalog #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
abdulraqeeb33 merged 1 commit into from
Oct 20, 2026
Merged

feat: [SDK-5581] add sdk_dispatcher_bootstrap to the feature catalog #28

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions kmp/src/commonMain/kotlin/com/onesignal/features/FeatureFlag.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,15 @@ enum class FeatureFlag(
"sdk_device_gesture_disabled",
FeatureActivationMode.IMMEDIATE,
),

/**
* Builds SDK dispatchers on a bootstrap thread instead of the first caller.
* APP_STARTUP because the pools live for the process. Absent means off.
*/
SDK_DISPATCHER_BOOTSTRAP(
"sdk_dispatcher_bootstrap",
FeatureActivationMode.APP_STARTUP,
),
;

fun isEnabledIn(enabledKeys: Set<String>): Boolean = enabledKeys.contains(key)
Expand Down
12 changes: 12 additions & 0 deletions kmp/src/commonTest/kotlin/com/onesignal/features/FeatureManagerTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,18 @@ class FeatureFlagTest {
FeatureFlag.SDK_DEVICE_GESTURE_DISABLED.activationMode,
)
}

@Test
fun dispatcherBootstrapIsAppStartupAndOffWhenAbsent() {
assertEquals("sdk_dispatcher_bootstrap", FeatureFlag.SDK_DISPATCHER_BOOTSTRAP.key)
assertEquals(
FeatureActivationMode.APP_STARTUP,
FeatureFlag.SDK_DISPATCHER_BOOTSTRAP.activationMode,
)
val manager = FeatureManager()
manager.refresh(emptyList(), applyAppStartupFlags = true)
assertFalse(manager.isEnabled(FeatureFlag.SDK_DISPATCHER_BOOTSTRAP))
}
}

class FeatureManagerTest {
Expand Down
Loading