Repository navigation
Jaden - Fix No-show Rate Insights percentage styling inconsistent with Figma (DONE Jaden)- #5785 - #5785
Open
Jaden300 wants to merge 1 commit into
Open
Jaden - Fix No-show Rate Insights percentage styling inconsistent with Figma (DONE Jaden)- #5785#5785Jaden300 wants to merge 1 commit into
Jaden300 wants to merge 1 commit into
Conversation
✅ Deploy Preview for highestgoodnetwork-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Jaden fix: No-show Rate Insights percentage styling inconsistent with Figma (DONE Jaden)- #5785
Description
Fixes the percentage values in the No-show Rate Insights section of /communityportal/reports/participation, which did not follow the red emphasis and weight from Figma. The fix from #5023 is no longer present on development, so this re-applies it against the current code.
The root cause was a CSS module class name mismatch: NoShowInsights.jsx used
styles.insightsPercentageandstyles.insightsPercentageDark, while the stylesheet only defined.insightPercentage. The classes resolved to undefined, so no percentage styles applied at all and the only color came from a hardcoded inline style.Related PRs
Follow-up to #5023 (Mani shashank - match no-show insights tab and percentage styling to Figma)
Changes made
Class name fix
.insightPercentageto.insightsPercentagein Participation.module.css so it matches the className used in NoShowInsights.jsxStyling
#d32f2f(4.98:1 on white, meets WCAG 4.5:1); plainredis about 4:1 and fails.insightsPercentageDarkuses#ff6b6binstead of the neutral--color-text-darkstyle={{ color: 'red' }}from NoShowInsights.jsx so styling lives in the CSS moduleScope
How to test
npm installandnpm run start:local