Repository navigation
Aditya Dhayapulay - Clarify Project Status duration metric - #5729
Open
adit24dhaya wants to merge 2 commits into
Open
adit24dhaya wants to merge 2 commits into
adit24dhaya wants to merge 2 commits into
Conversation
Explain that Project Status measures elapsed hours for projects completed in the selected period. Let cards grow to fit the definition and preserve unavailable-data handling. Cover single Active Projects rendering and duration edge cases. Include the complete original request and UI evidence for review. Task: 1558 (WBS 6ae059b9b664eb073c950a4c)
✅ Deploy Preview for highestgoodnetwork-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Use named native sections for the metric cards and reuse their readable dark-mode text rule for the duration explanation, removing its redundant override. Update accessible-region assertions while preserving API values and responsive behavior. Addresses Sonar findings on PR #5729, Task 1558.
|
Contributor
Author
|
Fixed both Sonar findings in a39fc06. Project Status cards now use native named sections, and the duration explanation shares the existing readable dark-mode card styling. Validation: 19 tests and 32 browser cases (360 assertions) passed across mobile/desktop widths, both themes and zero/missing/large hour values. Build and JS/CSS lint pass. Sonar confirms zero open issues and a passing Quality Gate. All three GitHub test jobs, CSS Modules and the preview now pass. The PR is conflict-free and ready for review. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
Original task request
Task 1558 · Original entry in HGN Phase II. Find Project Status: Duplicate “Active Projects” card and unclear Avg Project Duration unit.
Complete original entry captured directly from the source document before implementation:
The Project Status duration card does not explain what its hours measure. Rename it Avg Completed Project Duration (hours) and define it as start-to-completion time for projects completed in the selected period.
The duplicate Active Projects card was already removed in merged PR #5516. This PR preserves that change and adds regression coverage.
Related PRS (if any)
Frontend only. The existing backend endpoint already calculates average elapsed milliseconds between
startDateandcompletionDatefor completed projects, converts to hours and returnsunit: 'hrs'. See the current calculation. No paired backend change is required.Main changes explained
How to test
fix/project-status-cards, use Node 20 and start the existing frontend setup./bmdashboard/totalconstructionsummary, select a reporting period and expand Project Status.Validation at
413741f03e:Focused command:
Sonar cleanup follow-up (
a39fc06fcf, November 3)role="group"containers with named native sections and verify their accessible region names.!importantoverride and share the existing readable card-text styling in dark mode.Screenshots or videos of changes
Actual report and styles with synthetic API metrics; unrelated charts are stubbed:
Code/mobile screenshots and a short compressed walkthrough are also prepared locally in Week 5 for the weekly submission; the video has not been uploaded.
Note
Browser validation used the actual report, header, Redux action/reducer and theme handling with mocked API replies. No shared database writes were made. Authenticated dashboard E2E, live backend persistence, other browser engines and PDF export were not tested.