Repository navigation
Alekya - Fix dark mode date inputs in Financials (Cost Variance Trend, Cost Breakdown) - #5712
AlekyaJogini wants to merge 3 commits into
Conversation
✅ Deploy Preview for highestgoodnetwork-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
rahulrubugunday
left a comment
There was a problem hiding this comment.
I have reviewed your PR locally (frontend commit 59d3860, backend on development).
Working:
- Dark mode: Cost Variance Trend Start/End Date and Cost Breakdown From/To boxes are dark with readable text.
- Picking dates updates both charts (Cost Variance Trend filtered to May 5 to 15, Cost Breakdown total changed with a To date).
- Light mode: all four boxes are white with a thin border as before.
- Reason of Stoppage date range and the other date pickers (Loss Tracking, Paid Labor Cost, Issue Tracking, Global Distribution) are readable and open in both modes.
Needs fixing:
- Cost Breakdown From/To in dark mode: the calendar icon is dark on the dark box and hard to see. The new color-scheme: dark and the existing invert(1) filter on the icon cancel each other out. Please keep only one of them so the icon shows light.
iAbhi001
left a comment
There was a problem hiding this comment.
I tested PR #5712 locally at commit 59d3860 paired with the backend on development in dark mode. The dark input background styling resolves the bright white box issue, the text is legible, and the calendar popup opens and filters data cleanly. However, as shown in testing, the calendar picker indicator icon inside the "From" and "To" boxes of Cost Breakdown by Category is invisible/dark against the input background. Combining color-scheme: dark with the existing invert(1) filter cancels out the icon lightness. Please remove the redundant filter so the calendar icon renders with proper light contrast in dark mode. Requesting changes until this contrast issue is addressed.
|



Description
In dark mode, the date inputs in the Financials section of the Total Construction Summary were white. Cost Variance Trend (Start Date / End Date) showed white boxes, and Cost Breakdown by Category (From / To) showed white boxes with invisible text.
Location: Dashboard → Reports → Total Construction Summary → Financials (/bmdashboard/totalconstructionsummary)
Main changes explained:
How to test:
Screenshots:
Before (dark mode):
After (dark mode):


After (light mode, calendar open):

After scoping the global date picker rule:
Cost Variance Trend, light mode (thin border):

Reason of Stoppage, dark mode (same as before):
Reason of Stoppage, light mode (calendar opens):
Issue Tracking, dark mode (date boxes now dark, they were white before):
Note:
Tested the other date pickers on the page after scoping the global rule: Reason of Stoppage, Loss Tracking, Paid Labor Cost, Issue Tracking and Global Distribution all still work in light and dark mode, and Issue Tracking's date boxes are now dark in dark mode (they were forced white before). SonarCloud quality gate passes with 0 new issues.