Repository navigation
Mahika - fix: label Team Stats axis as Volunteers - #5666
mahikakakkad wants to merge 4 commits into
Conversation
✅ Deploy Preview for highestgoodnetwork-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
AaditTrivedi
left a comment
There was a problem hiding this comment.
Reviewed by Aadit Trivedi.
Verified the label against the data: the Team Stats bars plot inTeam.count and notInTeam.count from TeamStats.jsx (lines 67 and 73), which are volunteer counts, so "Volunteers" is the correct axis label and the previous "Total Hours Contributed" was inaccurate. No conflicts with development.
Approving.
rahulrubugunday
left a comment
There was a problem hiding this comment.
I have reviewed your PR locally (69e418a, backend on development) and it works as per requirement.
- Total Org Summary > Teams and Blue Squares > Team Stats: the x-axis now reads "Volunteers", matching the bars (Not In Team 1607, In Team 963).
- The label is readable in both dark and light mode.
- No conflicts with development.
iAbhi001
left a comment
There was a problem hiding this comment.
I have reviewed your PR locally (69e418ae5, backend on development) and it works as per requirement:
- Total Org Summary > Teams and Blue Squares > Team Stats: The x-axis now reads "Volunteers", matching the bars (
Not In Team 1607,In Team 963). - The label is clearly readable in both dark and light modes.
- No conflicts with
development.
Approving.
RevathiSrini
left a comment
There was a problem hiding this comment.
I reviewed and tested this PR locally using commit (69e418ae5).
The Team Stats chart correctly displays "Volunteers" as the X-axis label, which matches the volunteer counts shown for the In Team and Not In Team categories. I also verified that the chart renders properly in both light and dark modes, with no visible layout issues. Everything looks good!
RohSrik
left a comment
There was a problem hiding this comment.
I tested PR #5666 locally and verified the Team Stats chart under Dashboard → Total Org Summary → Teams and Blue Squares.
The x-axis label correctly displays "Volunteers," accurately representing the volunteer counts shown in the In Team and Not In Team bars.
I also tested the chart in both light and dark modes. The label is clearly visible, the bars display correctly, and there are no noticeable alignment, overlapping, or readability issues.
Overall, the changes mentioned in the PR description work as expected in both themes.
Sripriya03-hub
left a comment
There was a problem hiding this comment.
Tested this PR locally.
- The Team Stats axis now says Volunteers in light and dark mode
- When I hover over a bar, the tooltip still says Total Hours, so that label needs fixing too
Requesting changes.
10c41e8
|
Thanks for catching that @Sripriya03-hub! Updated the tooltip to say Volunteers too (whole numbers). Light / dark: |
vidiyala99
left a comment
There was a problem hiding this comment.
Tested at head 10c41e8 on the review box (FE only, mounted the Team Stats chart on its own because the Volunteer test account is redirected away from /totalorgsummary).
- The x-axis now reads "Volunteers" in light and dark mode.
- Hovering a bar shows "Volunteers: 1,619" (was "Total Hours"), so the point from the earlier change request (tooltip still said Total Hours) is fixed by the newest commit. A fractional value (652.4) rounds to "Volunteers: 652", and the Change line still shows (-2% / +3%).
- Other CustomTooltip callers keep their "Total Hours" default, since the new props are optional.
- CI: the one failing job is ActivityList.test.jsx (sorts activities by date), which this PR does not touch.
Approving.
Light mode: axis reads Volunteers, tooltip shows Volunteers: 1,619
Dark mode: same, tooltip shows Volunteers: 652 (rounded from 652.4)
Sripriya03-hub
left a comment
There was a problem hiding this comment.
Re-tested this locally on the latest commit.
- Hovering a Team Stats bar now shows Volunteers instead of Total Hours, in light and dark mode
- The axis still says Volunteers
- Other charts that use the same tooltip, like Work Distribution, still show Total Hours
- Unit tests pass and there are no merge conflicts with development
Approving.
012d35e
AaditTrivedi
left a comment
There was a problem hiding this comment.
Re-reviewed by Aadit Trivedi.
The changes look right: the Team Stats axis now reads "Volunteers," and CustomTooltip takes a valueLabel and formatValue so the tooltip matches, while other charts keep "Total Hours" by default. The PR's tests pass (9/9).
However, the branch now has merge conflicts with development (checked with git merge-tree).
Required action
Please update the branch with development and resolve the conflicts. Happy to re-review once updated.
vidiyala99
left a comment
There was a problem hiding this comment.
Approved again at head 012d35e. My 11/01 approval was on 10c41e8, and the only commit since is a test fix.
What changed
ActivityList.test.jsxnow clicks "Show Past Events" before the date sort test. That was the failing CI job I flagged last time: the mock activity dates are now in the past, so the default filter hid all of them and there was nothing to sort. The fix is correct and does not change the component.
How I checked
- Ran
ActivityList.test.jsx(5 of 5 pass) andCustomTooltip.test.jsx(4 of 4 pass) on the PR head. - CI:
testand SonarCloud pass now, and the deploy preview builds. - The Team Stats changes (
CustomTooltip.jsx,TeamStatsBarChart.jsx) are the same as in my last review, where I tested the "Volunteers" axis and tooltip in light and dark mode.
rahulrubugunday
left a comment
There was a problem hiding this comment.
I have re-reviewed your PR locally on the latest commit (012d35e, backend on development) in light and dark mode.
Works:
- Total Org Summary > Teams and Blue Squares > Team Stats: the x-axis label still reads "Volunteers".
- Hovering a bar shows "Volunteers: 1,621" / "Volunteers: 965" in the tooltip.
- Both work in light and dark mode.
Note: the branch now has a merge conflict with development in src/components/CommunityPortal/Activities/tests/ActivityList.test.jsx. Please resolve it before merging.
…ats-axis-label # Conflicts: # src/components/CommunityPortal/Activities/__tests__/ActivityList.test.jsx
5119436
|





Description
Fixes (PRIORITY URGENT) P1 Total Org Summary: Team Stats chart labels are wrong.
The Team Stats x-axis said "Total Hours Contributed", but the bars count volunteers (In Team / Not In Team). The axis now says "Volunteers".
(The "--0.02" change label from the same bug was already fixed in #5608.)
Related PRS (if any):
None (frontend only).
Main changes explained:
How to test:
npm installandnpm run start:localto run this PR locallyScreenshots or videos of changes:
Light mode:

Dark mode:

Note:
None.