Skip to content

Mahika - fix: label Team Stats axis as Volunteers - #5666

Open
mahikakakkad wants to merge 4 commits into
developmentfrom
mahika/team-stats-axis-label
Open

mahikakakkad wants to merge 4 commits into
developmentfrom
mahika/team-stats-axis-label

Conversation

@mahikakakkad

@mahikakakkad mahikakakkad commented Oct 17, 2026 •

Copy link
Copy Markdown
Contributor

Description

Fixes (PRIORITY URGENT) P1 Total Org Summary: Team Stats chart labels are wrong.
The Team Stats x-axis said "Total Hours Contributed", but the bars count volunteers (In Team / Not In Team). The axis now says "Volunteers".
(The "--0.02" change label from the same bug was already fixed in #5608.)

Related PRS (if any):

None (frontend only).

Main changes explained:

  • Update TeamStatsBarChart.jsx: x-axis label changed from "Total Hours Contributed" to "Volunteers"
  • CustomTooltip.jsx: added optional valueLabel and formatValue props (defaults unchanged, so other charts are not affected). Team Stats now shows "Volunteers: 1,619" on hover.

How to test:

  1. Check into current branch
  2. Do npm install and npm run start:local to run this PR locally
  3. Clear site data/cache
  4. Log in as admin user
  5. Go to Dashboard → Total Org Summary → Teams and Blue Squares → Team Stats
  6. Verify the x-axis label says "Volunteers"
  7. Verify this works in dark mode

Screenshots or videos of changes:

Light mode:
image

Dark mode:
image

Note:

None.

@netlify

netlify Bot commented Oct 17, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for highestgoodnetwork-dev ready!

Name Link
🔨 Latest commit 5119436
🔍 Latest deploy log https://app.netlify.com/projects/highestgoodnetwork-dev/deploys/6aed58a74b18005945b4003d
😎 Deploy Preview https://deploy-preview-5666--highestgoodnetwork-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

AaditTrivedi
AaditTrivedi previously approved these changes Oct 19, 2026

@AaditTrivedi AaditTrivedi left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed by Aadit Trivedi.

Verified the label against the data: the Team Stats bars plot inTeam.count and notInTeam.count from TeamStats.jsx (lines 67 and 73), which are volunteer counts, so "Volunteers" is the correct axis label and the previous "Total Hours Contributed" was inaccurate. No conflicts with development.

Approving.

@rahulrubugunday rahulrubugunday left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have reviewed your PR locally (69e418a, backend on development) and it works as per requirement.

  1. Total Org Summary > Teams and Blue Squares > Team Stats: the x-axis now reads "Volunteers", matching the bars (Not In Team 1607, In Team 963).
  2. The label is readable in both dark and light mode.
  3. No conflicts with development.
Image

@iAbhi001
iAbhi001 self-requested a review October 23, 2026 23:55
iAbhi001
iAbhi001 previously approved these changes Oct 24, 2026

@iAbhi001 iAbhi001 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have reviewed your PR locally (69e418ae5, backend on development) and it works as per requirement:

  1. Total Org Summary > Teams and Blue Squares > Team Stats: The x-axis now reads "Volunteers", matching the bars (Not In Team 1607, In Team 963).
  2. The label is clearly readable in both dark and light modes.
  3. No conflicts with development.

Approving.

Image

RevathiSrini
RevathiSrini previously approved these changes Oct 24, 2026

@RevathiSrini RevathiSrini left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed and tested this PR locally using commit (69e418ae5).
The Team Stats chart correctly displays "Volunteers" as the X-axis label, which matches the volunteer counts shown for the In Team and Not In Team categories. I also verified that the chart renders properly in both light and dark modes, with no visible layout issues. Everything looks good!

Image Image

RohSrik
RohSrik previously approved these changes Oct 24, 2026

@RohSrik RohSrik left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested PR #5666 locally and verified the Team Stats chart under Dashboard → Total Org Summary → Teams and Blue Squares.

The x-axis label correctly displays "Volunteers," accurately representing the volunteer counts shown in the In Team and Not In Team bars.

I also tested the chart in both light and dark modes. The label is clearly visible, the bars display correctly, and there are no noticeable alignment, overlapping, or readability issues.

Overall, the changes mentioned in the PR description work as expected in both themes.

Image

@Sripriya03-hub Sripriya03-hub left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this PR locally.

  • The Team Stats axis now says Volunteers in light and dark mode
  • When I hover over a bar, the tooltip still says Total Hours, so that label needs fixing too

Requesting changes.

@mahikakakkad

Copy link
Copy Markdown
Contributor Author

Thanks for catching that @Sripriya03-hub! Updated the tooltip to say Volunteers too (whole numbers). Light / dark:
teamstats-tooltip-dark
teamstats-tooltip-light

vidiyala99
vidiyala99 previously approved these changes Nov 1, 2026

@vidiyala99 vidiyala99 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested at head 10c41e8 on the review box (FE only, mounted the Team Stats chart on its own because the Volunteer test account is redirected away from /totalorgsummary).

  • The x-axis now reads "Volunteers" in light and dark mode.
  • Hovering a bar shows "Volunteers: 1,619" (was "Total Hours"), so the point from the earlier change request (tooltip still said Total Hours) is fixed by the newest commit. A fractional value (652.4) rounds to "Volunteers: 652", and the Change line still shows (-2% / +3%).
  • Other CustomTooltip callers keep their "Total Hours" default, since the new props are optional.
  • CI: the one failing job is ActivityList.test.jsx (sorts activities by date), which this PR does not touch.

Approving.

Light mode: axis reads Volunteers, tooltip shows Volunteers: 1,619

Image

Dark mode: same, tooltip shows Volunteers: 652 (rounded from 652.4)

Image

@one-community one-community added the High Priority - Please Review First This is an important PR we'd like to get merged as soon as possible label Nov 1, 2026
Sripriya03-hub
Sripriya03-hub previously approved these changes Nov 1, 2026

@Sripriya03-hub Sripriya03-hub left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-tested this locally on the latest commit.

  • Hovering a Team Stats bar now shows Volunteers instead of Total Hours, in light and dark mode
  • The axis still says Volunteers
  • Other charts that use the same tooltip, like Work Distribution, still show Total Hours
  • Unit tests pass and there are no merge conflicts with development

Approving.

Image Image

AaditTrivedi
AaditTrivedi previously approved these changes Nov 4, 2026

@AaditTrivedi AaditTrivedi left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-reviewed by Aadit Trivedi.

The changes look right: the Team Stats axis now reads "Volunteers," and CustomTooltip takes a valueLabel and formatValue so the tooltip matches, while other charts keep "Total Hours" by default. The PR's tests pass (9/9).

However, the branch now has merge conflicts with development (checked with git merge-tree).

Required action
Please update the branch with development and resolve the conflicts. Happy to re-review once updated.

vidiyala99
vidiyala99 previously approved these changes Nov 5, 2026

@vidiyala99 vidiyala99 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved again at head 012d35e. My 11/01 approval was on 10c41e8, and the only commit since is a test fix.

What changed

  • ActivityList.test.jsx now clicks "Show Past Events" before the date sort test. That was the failing CI job I flagged last time: the mock activity dates are now in the past, so the default filter hid all of them and there was nothing to sort. The fix is correct and does not change the component.

How I checked

  • Ran ActivityList.test.jsx (5 of 5 pass) and CustomTooltip.test.jsx (4 of 4 pass) on the PR head.
  • CI: test and SonarCloud pass now, and the deploy preview builds.
  • The Team Stats changes (CustomTooltip.jsx, TeamStatsBarChart.jsx) are the same as in my last review, where I tested the "Volunteers" axis and tooltip in light and dark mode.

rahulrubugunday
rahulrubugunday previously approved these changes Nov 6, 2026

@rahulrubugunday rahulrubugunday left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have re-reviewed your PR locally on the latest commit (012d35e, backend on development) in light and dark mode.

Works:

  1. Total Org Summary > Teams and Blue Squares > Team Stats: the x-axis label still reads "Volunteers".
  2. Hovering a bar shows "Volunteers: 1,621" / "Volunteers: 965" in the tooltip.
  3. Both work in light and dark mode.

Note: the branch now has a merge conflict with development in src/components/CommunityPortal/Activities/tests/ActivityList.test.jsx. Please resolve it before merging.

…ats-axis-label

# Conflicts:
#	src/components/CommunityPortal/Activities/__tests__/ActivityList.test.jsx
@sonarqubecloud

sonarqubecloud Bot commented Nov 6, 2026

Copy link
Copy Markdown

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

High Priority - Please Review First This is an important PR we'd like to get merged as soon as possible

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants