[anushkaadwivedii]

Description

Removing a reviewer currently permanently deletes a weekly grading document. This change hides the selected team's reviewer for the selected week while retaining their graded PRs, review counts, version history, and other weeks' records.

Implements task 45 in the PR Review Team Admin and Analytics Dashboard document (HGN task 1587).
Source: https://docs.google.com/document/d/11KglDgr_l3-8NdTLMGfu6YGmpGj-BSip_LD8IQbCtp8/edit

Original task

Related PRS (if any):

• Existing frontend: HighestGoodNetworkApp #5596 (merged).
• Existing backend: HGNRest Aditya K - Add DELETE endpoint for removing a reviewer from weekly grading #2375 (merged).
• The existing Remove Reviewer interface works with this backend change; no frontend product changes are required.

Main changes explained:

• Add isRemoved, removedAt, and removedBy to the weekly grading model.
• Replace permanent deletion with a scoped update of all matching reviewer snapshots for the selected team/week.
• Filter removed entries from grading-page responses, including legacy records that predate the new flag.
• Preserve graded PRs, counts, version history, other reviewers, teams, and weeks. No global model filter is added, so historical/reporting queries retain access to removed records.
• Keep accessPRTeamDashboard authorization and authenticated requestor auditing.
• Share a UTC week range between GET and removal so server timezone/DST cannot shift the selected week boundaries.
• Add router/database regression coverage including duplicate snapshots, repeated removals, stale saves, audit data, JWT authentication, and actual permission checks.

How to test:

1. Check out this branch and install the repository dependencies.
2. Run the weeklyGradingController unit/integration tests and weeklyGradingRouter test. The integration tests start their own disposable MongoDB server; do not point them at a shared database.
3. On a local frontend/backend with disposable fixture data, open /pr-grading-dashboard with accessPRTeamDashboard permission.
4. Seed a reviewer in the current week and a previous week, plus another reviewer. Confirm Cancel leaves the first reviewer visible.
5. Remove the first reviewer for the current week. Refresh the page: only the other reviewer remains in that week.
6. Select the previous week: the original reviewer and their graded PRs remain visible.
7. Inspect the database: the selected-week document still exists with grades/history intact, isRemoved: true, a removal timestamp, and the authenticated remover ID.
8. Confirm the analytics endpoint returns the same seeded insight data after removal.
9. Repeat as a user without permission: removal returns 403 and the data remains unchanged. Repeating a successful removal returns 404 without rewriting the original audit timestamp.

Screenshots or videos of changes:

Before removal

Hidden after refresh

Previous week retained

Records and PRs retained

Dark-mode confirmation

Dark mode after refresh

Validation

• 28/28 focused tests pass using real disposable MongoDB, real application JWT middleware, routes, models, and permission checks.
• Tests pass in Pacific and UTC timezones; all 28 also pass on the required Node v20.19.4.
• Prettier passes for all four changed files.
• Changed controller/model coverage: 96.94% statements, 89.18% branches, 100% functions, 96.87% lines in the final Pacific run.
• Original controller fails five of the new regression cases; fixed controller passes all ten integration cases.
• Changed files: ESLint 0 errors (2 warnings); git diff --check passes.
• Browser verification uses the unchanged frontend grading component from development commit 78e13192a, wired to the local fixed backend with disposable fixtures. Cancel, Remove, refresh persistence, and previous-week visibility were exercised. Removal and refresh persistence also passed with the existing dark-mode theme enabled.

Note:

Existing records need no migration: a missing removal flag is treated as visible. The API path and successful removal response stay compatible with the frontend. This change cannot recover documents already permanently deleted before deployment.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud