Repository navigation
Backend Release to Main [3.17] - #2399
Merged
Merged
Conversation
…fix/inventory-type-edit-delete-actions-backend
…fix/inventory-type-edit-delete-actions-backend
…into /invtypes/materials/:invtypeId
…rs passing invalid fuel type
…ositions list Give the job application page backend support on current development so applicants can submit without a JWT, resume uploads and confirmation emails are stored or sent, and the dropdown loads distinct job titles.
…oads The live form posts a payload JSON body plus questionFile_* fields, which multer.single(resume) rejected before save. Accept any multipart files so resume and second uploads are stored.
Extract answer-building and email helpers to satisfy Sonar cognitive complexity, and add coverage for invalid payload, save failures, and failed question-file uploads.
- Stop Blue Squares for late joiners - Close enough hours email should also remove the blue square - Add full name to Administrative Details
Deactivated volunteers are supposed to appear on the Weekly Summaries Report tab for the week their final day falls in, so they get credit for their last work and admins know to stop reporting on them. This does not happen today. The report computes finalWeekIndex relative to the week being requested and takes the absolute value of the difference. Because the frontend loads one tab at a time, the same end date produces a different index on each tab. As a result, a user deactivated last week matches no tab, and an active user with a scheduled end date is hidden from every tab. This commit adds getFinalWeekIndex, which measures an end date from the current week instead: - Returns 0 to 3 for This Week through Three Weeks Ago, using Pacific time week boundaries (Sunday to Saturday) - Returns null for end dates in a future week, older than three weeks, missing, or invalid - Rounds the day count between week starts so a daylight saving week cannot shift the result by one - Parses strings strictly as ISO 8601 so malformed dates return null Unit tests cover the tab mapping, the Saturday/Sunday boundary in Pacific time and in UTC, both daylight saving changes, and bad input. Limitations: the report does not use this helper yet. The index is only meaningful for users who are no longer active; callers must not apply it to scheduled separations. Related PRs: #1850 (HGNRest) and #4270 (HighestGoodNetworkApp) introduced the current finalWeekIndex logic.
Deactivated volunteers should still appear on the Weekly Summaries Report tab for the week they left. They currently appear on no tab, and some active volunteers are hidden as well. Three problems in weeklySummaries cause this: - finalWeekIndex was measured from the requested week with an absolute value, so it changed with the tab being loaded - The index was set after an early return for users with no time entries, so a user who logged no hours in their final week never received one - Active users with a scheduled end date received an index, which the frontend uses to hide them from every other tab This commit uses getFinalWeekIndex, which measures from the current week, sets the index before the early return, and sets it to null for active users. It also narrows the query. Since #1850 the report has loaded every inactive user ever created. It now loads active users plus inactive, non-paused users whose end date falls in the requested weeks. The filter excludes Paused rather than requiring Separated, because most existing inactive users on dev have no inactiveReason set. Effects: the weekly summaries email uses the same function, so it now lists active users plus users who left in the previous week, instead of all inactive users. Limitations: the frontend still hides any user with an endDate whose index does not match the tab, so active users with a scheduled end date remain hidden until the frontend is updated.
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
…iption_sanitization Aditya - Job descriptions: sanitize HTML before saving
…eduling Shubham Jakhete - Phase 1: Finishing followup fixes for PR 4558+1953: Fix Dark Mode, Date Selection, Time Selection and Scheduling the post for Mastodon (backend)
…fix/inventory-type-edit-delete-actions-backend
…final-week Shubham Jakhete - Create way to see deactivated people's last week on the Weekly Summaries Reports page (backend)
…-type-edit-delete-actions-backend Handika taking over for Alisha : (Fix) Edit & Delete Actions Not Working on Inventory Types
EOF Co-authored-by: Cursor <cursoragent@cursor.com>
Shreyas fix: make team code module for the profile page
one-community
temporarily deployed
to
Production
October 12, 2026 23:44 — with
GitHub Actions
Inactive
…e-email-issues Dhruv - Fix blue square related issues
one-community
temporarily deployed
to
Production
October 13, 2026 04:05 — with
GitHub Actions
Inactive
…middleware comments - Enhanced authorization logic in getFormResponses to use requestor from request body or user. - Updated middleware comments to clarify public and private access for job application forms and responses.
…s-backend Purav-taking-over-job-form-issues-backend
one-community
temporarily deployed
to
Production
October 13, 2026 07:46 — with
GitHub Actions
Inactive
Sundar: timer unable to stop after log time
one-community
temporarily deployed
to
Production
October 13, 2026 14:01 — with
GitHub Actions
Inactive
This was referenced Oct 14, 2026
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sitaram: 🔥 dark mode readability on Dashboard tasks, leaderboard hover and filter dropdowns- 5635+#2387, Roshini Seelamsetty : Add permissions logic for task extension count visibility- 5199+#2181, Shubham Jakhete - Phase 1: Finishing followup fixes for PR 4558+#1953: Fix Dark Mode, Date Selection, Time Selection and Scheduling the post for Mastodon (frontend)- 5593+#2373, Shubham Jakhete - Create way to see deactivated people's last week on the Weekly Summaries Reports page (frontend)- 5577+#2363, Handika taking over for Alisha : (fix) inventory type edit delete actions- 4826+#2043, Shreyas working on Fix Add Team function from Profile Page, including Quick Setup Selection of Teams and Team Codes- 5566+#2364, Gayatri - fix: count hours from volunteers deactivated later in period- #2389, Aditya - Job descriptions: sanitize HTML before saving- #2344, Dhruv - Fix blue square related issues- #2346, Purav-taking-over-job-form-issues-backend- #2333