Isha aking over for Kanishk: Add Event Popularity Analytics API Endpoints by kanishkagarwal6101 · Pull Request #1941 · OneCommunityGlobal/HGNRest

kanishkagarwal6101 · 2025-12-06T04:07:31Z

Description

This PR adds backend API endpoints for Event Popularity Analytics. Please verify everything shows properly in the frontend PR.

Related PRs

Frontend PR: PR 4514

Main Changes

New Controller

eventPopularityController.js - Implements four main endpoints:
- getPopularityMetrics() - Calculates popularity metrics by event type
- getEngagementMetrics() - Calculates engagement metrics (session duration, interaction rate)
- getEventValue() - Calculates estimated value per event
- getFormatComparison() - Compares Virtual vs In-Person event metrics

New Router

eventPopularityRouter.js - Defines API routes:
- GET /api/events/popularity - Get popularity metrics
- GET /api/events/engagement - Get engagement metrics
- GET /api/events/value - Get event value calculations
- GET /api/events/format-comparison - Get format comparison data

Route Registration

Updated src/startup/routes.js to register the new eventPopularityRouter

Reviewer Notes

Please verify everything shows properly in the frontend PR
All endpoints require JWT authentication

Anusha-Gali

Hi Kanishk,

I have reviewed your PR locally and the backend API responses are as per requirement.

sonarqubecloud · 2026-08-03T19:24:02Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
84.4% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

iAbhi001

Here is a clear, professional review comment you can post directly on the GitHub PR:

Hi @rithika-paii,

I reviewed and tested your PR locally, but I encountered a few issues while testing:

404 API Endpoint Errors:

On the reports page, the top analytics cards fail to load data, throwing Error: Request failed with status code 404.
Please verify that the backend API routes (/api/events/popularity, /api/events/engagement, /api/events/value, /api/events/format-comparison) are properly registered and reachable.

Broken Navigation ("Page Not Found"):

Clicking on Details (or navigating from event cards) redirects to a PAGE NOT FOUND error screen (404). Please double-check the route mapping/URLs defined for event details.

Could you please look into these routing and API endpoint issues?

sawantgayatri19

Hi @rithika-paii,

I reviewed and tested your PR locally, but I encountered a few routing and API issues that need to be resolved:

404 API Endpoint Errors:
- On the reports page, the top analytics cards fail to load data, throwing Error: Request failed with status code 404.
- Please verify that the backend API routes (/api/events/popularity, /api/events/engagement, /api/events/value, /api/events/format-comparison) are properly registered in src/startup/routes.js and reachable.
Broken Navigation ("Page Not Found"):
- Clicking on Details (or navigating from event cards) redirects to a (PAGE NOT FOUND) error screen (404). Please double-check the route mapping and URLs defined for event details.

Could you please look into these routing and API endpoint issues so we can proceed with merging?

DeepighaJ

Tested the endpoints locally, all the 4 the api endpoints returns 500 error "Failed to fetch event"

AdiDubbs

The controller structure is clear, and the added test suite passes locally.

The date handling needs a fix before merge: a date-only endDate becomes UTC midnight, so $lte excludes events later that same day. Invalid or reversed ranges are also not rejected. All four endpoints use the same pattern, so a shared helper and boundary tests would keep the metrics consistent.

AdiDubbs · 2026-08-08T23:19:24Z

+      if (startDate || endDate) {
+        query.date = {};
+        if (startDate) query.date.$gte = new Date(startDate);
+        if (endDate) query.date.$lte = new Date(endDate);


new Date('2026-08-08') is UTC midnight, so $lte excludes every event later on August 8. A request for August 1–8 therefore omits data from the end date itself.

All four endpoints repeat this pattern, and invalid or reversed ranges are not rejected. injuryCategoryController.js already handles date-only bounds by advancing the end date and using $lt, while returning a 400 for invalid dates. A shared helper plus a boundary test would keep these endpoints consistent.

- Created eventPopularityController with metrics calculation functions - Implemented getPopularityMetrics endpoint for event type breakdown - Implemented getEngagementMetrics endpoint for session analytics - Implemented getEventValue endpoint for estimated value calculations - Implemented getFormatComparison endpoint for Virtual vs In-Person comparison - Created eventPopularityRouter with all API routes - Registered router in startup/routes.js - Added proper error handling and logging - All endpoints support date range filtering via query parameters

…range filtering on event popularity endpoints

…ntroller to reduce duplication

sonarqubecloud · 2026-10-06T23:58:48Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
86.5% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

vidiyala99

Tested the new head 56ce0f0 on a test server against the shared dev data (207 events), calling the four endpoints directly as Administrator (read-only). The controller tests pass (eventPopularityController.test.js, 20/20).

Earlier review items:

Routes: GET /api/events/popularity, /events/engagement, /events/value and /events/format-comparison all return 200 with data now (the 404 and 500 responses reported in August are gone).
Date-only endDate: fixed. startDate=2026-10-08&endDate=2026-10-08 returns the 3 events stored as 2026-10-08T07:00:00Z, and 2026-10-01 to 2026-10-08 returns exactly the 11 events in that range, so events later on the end day are included.
Invalid dates: startDate=notadate returns 400 "Invalid startDate or endDate (use YYYY-MM-DD or ISO)".
Consistency: total attendees agree between popularity (sum of the per-type totalAttendees) and engagement: both 190, which matches the events' currentAttendees.

Notes, not blocking:

Format comparison silently drops events with no location. Dev has 179 "Virtual" and 24 "In person" events, plus 4 with a blank location ("" three times, " " once). format-comparison returns virtual 179 events / 95 attendees and in-person 24 / 49, so those 4 events and 46 attendees disappear, and its totals no longer match the other endpoints (207 events, 190 attendees). An "unspecified" bucket (after trimming) would keep the numbers consistent.
A reversed range isn't rejected: startDate=2026-12-31&endDate=2020-01-01 returns 200 {"metrics":[]}. Returning 400 like the invalid-date case would make a swapped date picker easier to spot.

Approving.

one-community · 2026-11-06T02:36:01Z

Thank you all, merging!

Fixed

kanishkagarwal6101 mentioned this pull request Dec 6, 2025

Isha taking over for Kanishk: Complete Event Popularity Analytics Visualization OneCommunityGlobal/HighestGoodNetworkApp#4514

Merged

Anusha-Gali approved these changes Dec 17, 2025

View reviewed changes

one-community changed the title ~~Kanishk: Add Event Popularity Analytics API Endpoints~~ XXX taking over for Kanishk: Add Event Popularity Analytics API Endpoints May 3, 2026

one-community added Do Not Review Do not review or look at code without full context Needs New Developer This is a PR that is partially developed but needs someone new to take it over and finish it. labels May 3, 2026

rithika-paii changed the title ~~XXX taking over for Kanishk: Add Event Popularity Analytics API Endpoints~~ Rithika taking over for Kanishk: Add Event Popularity Analytics API Endpoints Jun 12, 2026

rithika-paii force-pushed the kanishk_event_popularity_analytics_backend branch from 93557cd to 65f983b Compare July 16, 2026 20:18

rithika-paii force-pushed the kanishk_event_popularity_analytics_backend branch from 65f983b to 15bdfec Compare August 3, 2026 14:59

iAbhi001 self-requested a review August 4, 2026 19:52

iAbhi001 previously requested changes Aug 4, 2026

View reviewed changes

sawantgayatri19 previously requested changes Aug 4, 2026

View reviewed changes

DeepighaJ previously requested changes Aug 7, 2026

View reviewed changes

AdiDubbs previously requested changes Aug 8, 2026

View reviewed changes

kanishkagarwal6101 and others added 6 commits September 12, 2026 18:57

chore: add .claude/ to gitignore

f74830f

fix: prevent NoSQL injection via unvalidated format query param

d625e53

test: add coverage for eventPopularityController

b857ab8

fix: harden format validation to fully break taint chain for SonarQube

02ad90c

fix: resolve route collision causing 404/500s and fix inclusive date-…

5a0ae1e

…range filtering on event popularity endpoints

rithika-paii force-pushed the kanishk_event_popularity_analytics_backend branch from abe38bf to 5a0ae1e Compare September 13, 2026 01:28

rithika-paii and others added 4 commits September 19, 2026 07:15

refactor: extract shared query and error helpers in eventPopularityCo…

f0ec3f0

…ntroller to reduce duplication

chore: merge development into event popularity analytics backend

a64677b

chore: remove unrelated gitignore change

b7b777e

fix: event sorting and analytics route order

56ce0f0

vidiyala99 approved these changes Oct 9, 2026

View reviewed changes

one-community changed the title ~~Rithika taking over for Kanishk: Add Event Popularity Analytics API Endpoints~~ Isha aking over for Kanishk: Add Event Popularity Analytics API Endpoints Nov 2, 2026

one-community merged commit 9a170f3 into development Nov 6, 2026
4 checks passed

Navigation Menu

Repository navigation

Isha aking over for Kanishk: Add Event Popularity Analytics API Endpoints - #1941

Isha aking over for Kanishk: Add Event Popularity Analytics API Endpoints#1941
one-community merged 10 commits into
developmentfrom
kanishk_event_popularity_analytics_backend

kanishkagarwal6101 commented Dec 6, 2025

Uh oh!

Anusha-Gali left a comment

Uh oh!

sonarqubecloud Bot commented Aug 3, 2026

Uh oh!

iAbhi001 left a comment

Uh oh!

sawantgayatri19 left a comment

Uh oh!

DeepighaJ left a comment

Uh oh!

AdiDubbs left a comment

Uh oh!

AdiDubbs Aug 8, 2026

Uh oh!

sonarqubecloud Bot commented Oct 6, 2026

Uh oh!

vidiyala99 left a comment

Uh oh!

one-community commented Nov 6, 2026

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

Conversation

kanishkagarwal6101 commented Dec 6, 2025

Description

Related PRs

Main Changes

New Controller

New Router

Route Registration

Reviewer Notes

Uh oh!

Anusha-Gali left a comment

Choose a reason for hiding this comment

Uh oh!

sonarqubecloud Bot commented Aug 3, 2026

Quality Gate passed

Uh oh!

iAbhi001 left a comment

Choose a reason for hiding this comment

Uh oh!

sawantgayatri19 left a comment

Choose a reason for hiding this comment

Uh oh!

DeepighaJ left a comment

Choose a reason for hiding this comment

Uh oh!

AdiDubbs left a comment

Choose a reason for hiding this comment

Uh oh!

AdiDubbs Aug 8, 2026

Choose a reason for hiding this comment

Uh oh!

sonarqubecloud Bot commented Oct 6, 2026

Quality Gate passed

Uh oh!

vidiyala99 left a comment

Choose a reason for hiding this comment

Uh oh!

one-community commented Nov 6, 2026

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants