Repository navigation
Conversation
Store the error when validation fails, and `HashRoot` will then return it.
HashTreeRootWith runs the check of MarshalSSZ before the hash call.
syjn99
marked this pull request as ready for review
November 18, 2026 03:12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #27.
HashTreeRootWithruns the check ofMarshalSSZbefore each bitfield hash call (ssz.ValidateBitlist,ssz.ValidateProgressiveBitlist,ssz.ValidateBitvector). It returned a root for a Bitlist with no delimiter bit or above its limit, and for a Bitvector with set padding bits.PutBitlistandPutProgressiveBitlistvalidate their input, andHashRootreturns the first error. A zero last byte madePutProgressiveBitlistpanic.ErrEmptyBitlist, so an empty bitlist still gives that error.ProgBits(a progressive bitlist) togenfixture, and checkHashTreeRootin its bitfield tests.Prysm
developregenerated with this branch, compared with #27: patch🤖 Generated with Claude Code