Skip to content

chore(deps): declare ansible-core >=2.19 floor and pin Debian 12 policy - #175

Merged
Oddly merged 1 commit into
mainfrom
chore/eol-followup
Aug 4, 2026
Merged

chore(deps): declare ansible-core >=2.19 floor and pin Debian 12 policy#175
Oddly merged 1 commit into
mainfrom
chore/eol-followup

Conversation

@Oddly

@Oddly Oddly commented Aug 4, 2026

Copy link
Copy Markdown
Owner

Closes #116.

The monthly EOL check flagged ansible-core 2.18 (EOL 2026-05-31), ansible-core 2.19 (EOL 2026-11-30), and Debian 12 Bookworm (EOL 2026-07-11). galaxy.yml had no requires_ansible at all, so 2.18 users hit a stray syntax failure somewhere in the tasks instead of a resolvable "this collection needs 2.19 or newer" up front. Declaring >=2.19 gives them the readable error. Plan is to bump to >=2.20 once 2.19 goes EOL in November — noted inline.

For Debian 12: keep it in the full CI matrix as best-effort. Community users are still on Bookworm, nothing in the collection actively breaks on it, and dropping it now with no user complaints is a step ahead of what the ecosystem asks for. Added a comment above the image mapping in molecule/shared/create.yml recording the EOL date and the plan to drop once the Bookworm pre-baked image stops building cleanly.

No code path changes; the check_eol workflow keeps running monthly and will re-file if 2.19 catches up to its EOL without a bump landing.

Summary by CodeRabbit

  • Documentation
    • Documented Debian 12’s continued best-effort CI support and planned removal timeline.
    • Updated the minimum supported Ansible version to 2.19.0.
    • Documented the planned future transition to Ansible 2.20 after version 2.19 reaches end of life.

@Oddly Oddly added the ci:run Trigger gated pull request CI label Aug 4, 2026
@Oddly
Oddly enabled auto-merge (squash) August 4, 2026 08:44
@github-actions github-actions Bot removed the ci:run Trigger gated pull request CI label Aug 4, 2026
@coderabbitai

coderabbitai Bot commented Aug 4, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

The project now requires Ansible 2.19 or newer. The CI configuration documents Debian 12’s EOL status, continued best-effort coverage, and planned removal.

Changes

EOL support policy

Layer / File(s) Summary
Support policy declarations
meta/runtime.yml, molecule/shared/create.yml
The Ansible version floor increases to 2.19. Comments document Ansible and Debian 12 EOL dates and planned future updates.

Estimated code review effort: 1 (Trivial) | ~5 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Linked Issues check ⚠️ Warning The Ansible floor is updated, but Debian 12 remains in the CI matrix despite issue [#116] requiring a matrix update for EOL dependencies. Remove Debian 12 from the active CI matrix, or document an approved exception with a defined removal date.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the Ansible version floor and Debian 12 policy changes.
Out of Scope Changes check ✅ Passed The changes address dependency versioning and Debian 12 CI policy, which are within the scope of issue [#116].
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/eol-followup

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Oddly
Oddly force-pushed the chore/eol-followup branch from d473553 to f8b46f2 Compare August 4, 2026 09:18
@Oddly Oddly added the ci:run Trigger gated pull request CI label Aug 4, 2026
@github-actions github-actions Bot removed the ci:run Trigger gated pull request CI label Aug 4, 2026
Closes #116.

The monthly EOL check flagged three items:

- ansible-core 2.18 went EOL 2026-05-31
- ansible-core 2.19 goes EOL 2026-11-30
- Debian 12 (Bookworm) went EOL 2026-07-11

galaxy.yml had no requires_ansible constraint, so 2.18 users got a
random syntax error somewhere in the role tasks the first time they
hit code that only works on 2.19+. Declaring ">=2.19" gives them a
resolvable 'this collection requires ansible-core 2.19 or newer'
message instead. Bump to ">=2.20" once 2.19 goes EOL in November.

Debian 12 stays in the full CI matrix as best-effort — community
users are still running it and there's no functional reason to drop
it today. Left a comment above the image mapping in shared/create.yml
noting the EOL date and the plan to drop the image once Trixie hits
its 1-year mark and Bookworm images stop building cleanly.
@Oddly
Oddly force-pushed the chore/eol-followup branch from f8b46f2 to 5d3ec2d Compare August 4, 2026 09:57
@Oddly Oddly added the ci:run Trigger gated pull request CI label Aug 4, 2026
@github-actions github-actions Bot removed the ci:run Trigger gated pull request CI label Aug 4, 2026

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@meta/runtime.yml`:
- Around line 2-5: Align the documented and tested Ansible versions with the
requires_ansible floor in runtime metadata: update the README’s supported
version text from Ansible 2.18+ to 2.19+, and adjust the test_plugins workflow
matrix to remove Ansible 2.18 or explicitly mark it as non-supported best-effort
coverage.
🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: f2b02171-52c7-4b7d-9ac2-4749767eab96

📥 Commits

Reviewing files that changed from the base of the PR and between d473553 and 5d3ec2d.

📒 Files selected for processing (2)
  • meta/runtime.yml
  • molecule/shared/create.yml
🚧 Files skipped from review as they are similar to previous changes (1)
  • molecule/shared/create.yml

Comment thread meta/runtime.yml
Comment on lines +2 to +5
# ansible-core floor: 2.18 went EOL on 2026-05-31, 2.19 goes EOL 2026-11-30.
# Declare 2.19 as the floor now so 2.18 users see a resolvable error message
# instead of a stray syntax failure; bump to 2.20 once 2.19 goes EOL.
requires_ansible: ">=2.19.0"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🗄️ Data Integrity & Integration | 🟠 Major | ⚡ Quick win

Align documentation and CI with the new Ansible floor.

The metadata now requires ansible-core >=2.19.0, but:

  • README.md, Line [106] still documents Ansible 2.18+. Update it to 2.19+.
  • .github/workflows/test_plugins.yml, Lines [64-65] still includes 2.18. Remove it from the supported or gating matrix, or mark it explicitly as non-supported best-effort coverage.

Otherwise, users can follow documentation that leads to a metadata rejection, and CI can validate a version that the collection no longer supports.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@meta/runtime.yml` around lines 2 - 5, Align the documented and tested Ansible
versions with the requires_ansible floor in runtime metadata: update the
README’s supported version text from Ansible 2.18+ to 2.19+, and adjust the
test_plugins workflow matrix to remove Ansible 2.18 or explicitly mark it as
non-supported best-effort coverage.

@Oddly
Oddly merged commit d0fd51c into main Aug 4, 2026
129 of 133 checks passed
@Oddly
Oddly deleted the chore/eol-followup branch August 4, 2026 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

EOL dependencies detected

1 participant