chore(deps): declare ansible-core >=2.19 floor and pin Debian 12 policy - #175
Conversation
📝 WalkthroughWalkthroughThe project now requires Ansible 2.19 or newer. The CI configuration documents Debian 12’s EOL status, continued best-effort coverage, and planned removal. ChangesEOL support policy
Estimated code review effort: 1 (Trivial) | ~5 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
d473553 to
f8b46f2
Compare
Closes #116. The monthly EOL check flagged three items: - ansible-core 2.18 went EOL 2026-05-31 - ansible-core 2.19 goes EOL 2026-11-30 - Debian 12 (Bookworm) went EOL 2026-07-11 galaxy.yml had no requires_ansible constraint, so 2.18 users got a random syntax error somewhere in the role tasks the first time they hit code that only works on 2.19+. Declaring ">=2.19" gives them a resolvable 'this collection requires ansible-core 2.19 or newer' message instead. Bump to ">=2.20" once 2.19 goes EOL in November. Debian 12 stays in the full CI matrix as best-effort — community users are still running it and there's no functional reason to drop it today. Left a comment above the image mapping in shared/create.yml noting the EOL date and the plan to drop the image once Trixie hits its 1-year mark and Bookworm images stop building cleanly.
f8b46f2 to
5d3ec2d
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@meta/runtime.yml`:
- Around line 2-5: Align the documented and tested Ansible versions with the
requires_ansible floor in runtime metadata: update the README’s supported
version text from Ansible 2.18+ to 2.19+, and adjust the test_plugins workflow
matrix to remove Ansible 2.18 or explicitly mark it as non-supported best-effort
coverage.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: f2b02171-52c7-4b7d-9ac2-4749767eab96
📒 Files selected for processing (2)
meta/runtime.ymlmolecule/shared/create.yml
🚧 Files skipped from review as they are similar to previous changes (1)
- molecule/shared/create.yml
| # ansible-core floor: 2.18 went EOL on 2026-05-31, 2.19 goes EOL 2026-11-30. | ||
| # Declare 2.19 as the floor now so 2.18 users see a resolvable error message | ||
| # instead of a stray syntax failure; bump to 2.20 once 2.19 goes EOL. | ||
| requires_ansible: ">=2.19.0" |
There was a problem hiding this comment.
🗄️ Data Integrity & Integration | 🟠 Major | ⚡ Quick win
Align documentation and CI with the new Ansible floor.
The metadata now requires ansible-core >=2.19.0, but:
README.md, Line [106] still documentsAnsible 2.18+. Update it to2.19+..github/workflows/test_plugins.yml, Lines [64-65] still includes2.18. Remove it from the supported or gating matrix, or mark it explicitly as non-supported best-effort coverage.
Otherwise, users can follow documentation that leads to a metadata rejection, and CI can validate a version that the collection no longer supports.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@meta/runtime.yml` around lines 2 - 5, Align the documented and tested Ansible
versions with the requires_ansible floor in runtime metadata: update the
README’s supported version text from Ansible 2.18+ to 2.19+, and adjust the
test_plugins workflow matrix to remove Ansible 2.18 or explicitly mark it as
non-supported best-effort coverage.
Closes #116.
The monthly EOL check flagged ansible-core 2.18 (EOL 2026-05-31), ansible-core 2.19 (EOL 2026-11-30), and Debian 12 Bookworm (EOL 2026-07-11).
galaxy.ymlhad norequires_ansibleat all, so 2.18 users hit a stray syntax failure somewhere in the tasks instead of a resolvable "this collection needs 2.19 or newer" up front. Declaring>=2.19gives them the readable error. Plan is to bump to>=2.20once 2.19 goes EOL in November — noted inline.For Debian 12: keep it in the full CI matrix as best-effort. Community users are still on Bookworm, nothing in the collection actively breaks on it, and dropping it now with no user complaints is a step ahead of what the ecosystem asks for. Added a comment above the image mapping in
molecule/shared/create.ymlrecording the EOL date and the plan to drop once the Bookworm pre-baked image stops building cleanly.No code path changes; the check_eol workflow keeps running monthly and will re-file if 2.19 catches up to its EOL without a bump landing.
Summary by CodeRabbit