fix(certs): make *_cert_will_expire_soon overridable from playbooks - #171
fix(certs): make *_cert_will_expire_soon overridable from playbooks#171Oddly wants to merge 1 commit into
Conversation
|
Warning Review limit reached
Next review available in: 25 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (10)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
f580639 to
3d9ab78
Compare
Closes #157. The five cert-renewal trigger flags (elasticsearch_cert_will_expire_soon, beats_cert_will_expire_soon, kibana_cert_will_expire_soon, logstash_cert_will_expire_soon, elasticstack_ca_will_expire_soon) lived in each role's vars/main.yml, which outranks play vars, so a playbook that did 'vars: elasticsearch_cert_will_expire_soon: true' saw its value silently reverted when the role re-imported vars/main.yml. Move each flag to the corresponding defaults/main.yml with an @var docblock explaining that it is normally flipped automatically by cert_check_expiry and only needs to be set from a playbook to force renewal without touching the buffer. Runtime mutation via set_fact still wins (set_fact produces a host fact, which beats a role default), so cert_check_expiry keeps working.
3d9ab78 to
038e163
Compare
1 participant
Closes #157.
The five
*_cert_will_expire_soonflags — one per role plus the CA one on elasticstack — sat invars/main.yml, which sits above play vars in the Ansible precedence hierarchy. That meant a playbook doingvars: elasticsearch_cert_will_expire_soon: truehad no effect: as soon as the role was included, the value got reverted tofalsefromvars/main.yml, and renewal never fired. I ran into this myself writing the cert-renewal molecule scenario for #155 and had to work around it by manipulating_cert_expiration_bufferinstead.Moving each flag to
defaults/main.ymlwith an@vardocblock puts them in the precedence tier every other tunable lives in, so play vars, inventory vars, and command-line-eall win as expected. Runtime mutation fromcert_check_expirystill wins on top of both because it goes throughset_fact(host fact, higher precedence than either).Documented that these are normally flipped automatically and only need to be set manually to force renewal outside the buffer window. No behaviour change for callers that never set them.