Nco/releng/sw 2026 5 1#63
Open
ncouvert wants to merge 8 commits into
Open
Conversation
ncouvert
force-pushed
the
nco/enh/templates
branch
from
6ea6cad to
4580728
Compare
ncouvert
force-pushed
the
nco/releng/sw-2026-5-1
branch
4 times, most recently
from
83c9afd to
66fb072
Compare
ncouvert
force-pushed
the
nco/releng/sw-2026-5-1
branch
from
66fb072 to
ae09b9e
Compare
This was
linked to
issues
Jun 11, 2026
lfasani
reviewed
Jun 11, 2026
lfasani
left a comment
lfasani
left a comment
Collaborator
There was a problem hiding this comment.
In "[9] Add DependencyLink to add real delay between dependencies" commit, please detail what you have done.
It seems that you have done much more that DependencyLink.
For example editTask service is modified or I can see calculation option.
lfasani
requested changes
Jun 11, 2026
|
|
||
| private void followTaskMoveDependency(Task sourceTask) { | ||
| List<Task> dependencies = new ArrayList<>(); | ||
| private void followMoveDependency(DependencyRelatedObject sourceObject) { |
| } | ||
|
|
||
| private static boolean isDuplicateOrCycle(Task sourceTask, Task targetTask) { | ||
| private boolean isDuplicateOrCycle(DependencyRelatedObject sourceObject, DependencyRelatedObject targetObject) { |
| } | ||
| } | ||
|
|
||
| private void followTaskMoveDependencyWorkpackage(List<Workpackage> targetWorkpackages, Workpackage sourceWorkpackage) { |
| } | ||
| } | ||
|
|
||
| private void followTaskMoveDependencyTask(List<Task> targetTasks, Task sourceTask) { |
| } | ||
| } | ||
|
|
||
| private void setWorkpackageNewDates(Workpackage workpackage, DependencyLink dep) { |
lfasani
reviewed
Jun 11, 2026
lfasani
left a comment
lfasani
left a comment
Collaborator
There was a problem hiding this comment.
Try an interactive rebase and regenerate the meta-model at each commit because it seems that you do style changes in a commit and the reverse in next commit.
ncouvert
force-pushed
the
nco/releng/sw-2026-5-1
branch
2 times, most recently
from
40e9177 to
c3455b6
Compare
Add a new DependencyLink element to the metamodel to support explicit delays between dependent tasks. Introduce a calculation mode for Gantt tasks defining how dates are computed: - Start-End - End-Duration - Start-Duration This commit introduces an impact between task dependencies. The JavaService has been updated to reflect these changes. Issue: #9
ncouvert
force-pushed
the
nco/releng/sw-2026-5-1
branch
from
c3455b6 to
d3371a4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the switch to SW 2026.5.1 and all the commits of the May Milestone