implementation of ADC calibration test - #739
Open
a2ronmeade wants to merge 8 commits into
Open
a2ronmeade wants to merge 8 commits into
a2ronmeade wants to merge 8 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
in a similar manner to IVcurve CSV to ROOT and SLDO CSV to ROOT, we make plots of ADC calibration to root.
ADC calibration does (from issue #726 ):
make a new test that:
reads from low voltage channel for temp
at the same time read temp from chip and Vin from the chip
store those in some way:
Vin and Temp from chip can be stored in a monitoring file
Data from power supply in a CSV file
Then find out how to combine those and make a plot
plot of Vin from chip and Vin from power supply
Checklist
Before submitting this PR, please ensure the following:
Related Issues
#726
Changes Made
adds tests as described above
Testing
ran on sh0216, rh0215
Additional Requirements:
FESettings.py:
HWSettings.py: in HWSettings_DictB
MonitoringSettings.py:
RootFilesDict.py:
TestSequences.py: add to Test_to_Ph2ACF_Map:
in InnerTrackerTests/Analysis:
Found here: https://github.com/a2ronmeade/storage/blob/main/ADCCALIB_CSV_to_plot_and_root.py
in felis/core_methods/init.py
in felis/felis.py: in get_actionable_summary:
in felis/core_methods:
Found here: https://github.com/a2ronmeade/storage/blob/main/get_adctemp.py