Flexible runtime config handling - #3017
Merged
Merged
Conversation
schaefi
force-pushed
the
flexible_runtime_config_handling
branch
from
July 3, 2026 09:17
c40aa3f to
31b9075
Compare
|
This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed as part of the community meeting. |
schaefi
force-pushed
the
flexible_runtime_config_handling
branch
from
September 8, 2026 13:06
31b9075 to
159660e
Compare
schaefi
marked this pull request as ready for review
September 8, 2026 13:06
The runtime config file nested key=value settings
into lists like this [{key1=value1}, {key2=value2}].
This layout style is unnecessary complex and also
makes it hard to implement a straight forward merge
strategy for standard data types. This commit
refactors the layout to the necessary data structure.
So far the runtime config dicts after yaml.safe_load were merged together via python's dict.update() method. However, in kiwi the runtime config contains nested dictionaries and lists which always causes an overwrite and does not allow for add-on settings of the same configuration key. This commit adds a recursive merge strategy to make this more flexible. This is related to Issue #3014
Several build tests uses a custom kiwi settings file. These files needs to be adapted to the new layout
schaefi
force-pushed
the
flexible_runtime_config_handling
branch
from
September 9, 2026 09:10
159660e to
0eb2c05
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This refactor is two fold
Refactor runtime config layout style
The runtime config file nested key=value settings into lists like this
[{key1=value1}, {key2=value2}]. This layout style is unnecessary complex and also makes it hard to implement a straight forward merge strategy for standard data types. This commit refactors the layout to the necessary data structure.Refactor merge strategy for runtime config files
So far the runtime config dicts after yaml.safe_load were merged together via python's dict.update() method. However, in kiwi the runtime config contains nested dictionaries and lists which always causes an overwrite and does not allow for add-on settings of the same configuration key. This commit adds a recursive merge strategy to make this more flexible. This is related to Issue #3014