Collapse enzyme wb, ws, h - #511
Conversation
|
@Steven-Roberts this representation might make partitioning easier aswell |
|
Thanks @lukelowry for looking at this. Updating these local vector is on our todo list, and this should work, now that we are storing the current injections as local variables. I would still prioritize merging the models you need for the 10K over this change. |
I agree, definitely |
|
@pelesh I believe this formulation of the system gives me the most flexibility in EMT models. On my end, I would be okay with splitting off from Phasor Dynamics after this. |
04b5ede to
fe25d96
Compare
fe25d96 to
f118e08
Compare
Description
Refactors PhasorDynamics components to use a consistent internal/external variable and residual interface (thank you for the inspo @alexander-novo). This removes the separate
wb,ws, andhpaths, simplifies Enzyme Jacobian generation, and makes residual ownership clearer without changing model behavior.Proposed changes
Component.Checklist
-Wall -Wpedantic -Wconversion -Wextra.Further comments
This demonstrates that we don't need to give special treatment to
Bus, and we can haveBusinherit fromComponent, which dramatically simplifiesSystemModeland signal orchestration. Personally, this is much easier to document and implement. MOST IMPORTANTLY: this internal/external formulation can allow us to make the residual evaluation order independent, which (I think) is better for partitioning and parallelization.cc @nkoukpaizan
Draft just so others can see, I may need to break this up