Skip to content

Update all template formatting #505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
PhilipFackler wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

Update all template formatting #505

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
91b94c6
Updated template formatting for AD, LA, MM, and Models
PhilipFackler Jun 19, 2026
f32f90d
Updated template formatting for Solver and Util
PhilipFackler Jul 21, 2026
618fb79
Update template formatting for tests
PhilipFackler Jul 22, 2026
c421b30
Update GridKit/LinearAlgebra/SparseMatrix/CsrMatrix.cpp
PhilipFackler Aug 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
64 changes: 32 additions & 32 deletions GridKit/AutomaticDifferentiation/Enzyme/LowerSparseStorage.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,8 +191,8 @@ namespace GridKit
*
* @details This takes in a row, column and value and stores them in buffers
*
* @tparam ScalarT - scalar data type
* @tparam IdxT - matrix index data type
* @tparam scalar_type - scalar data type
* @tparam index_type - matrix index data type
*
* @param[in] val - value to be stored
* @param[in] row - row to be stored
Expand All @@ -205,35 +205,35 @@ namespace GridKit
* @param[in,out] vals - buffer where val will be stored
* @param[in,out] nnz - number of nonzeros
*/
template <typename ScalarT, typename IdxT>
template <typename scalar_type, typename index_type>
__attribute__((always_inline)) static void sparse_store(
ScalarT val,
IdxT row,
IdxT col,
ScalarT scaling,
const IdxT* row_indices,
const IdxT* col_indices,
IdxT* rows,
IdxT* cols,
ScalarT* vals,
IdxT& nnz)
scalar_type val,
index_type row,
index_type col,
scalar_type scaling,
const index_type* row_indices,
const index_type* col_indices,
index_type* rows,
index_type* cols,
scalar_type* vals,
index_type& nnz)
{
if (val == 0.0)
return;

row /= sizeof(ScalarT);
row /= sizeof(scalar_type);

// this template nightmare is because __attribute__((enzyme_sparse_accumulate)) does not support templates yet
if constexpr (std::is_same<IdxT, size_t>::value)
if constexpr (std::is_same<index_type, size_t>::value)
{
if constexpr (std::is_same<IdxT, float>::value)
if constexpr (std::is_same<index_type, float>::value)
inner_store_float_size_t(row, col, val, scaling, row_indices, col_indices, rows, cols, vals, nnz);
else
inner_store_double_size_t(row, col, val, scaling, row_indices, col_indices, rows, cols, vals, nnz);
}
else if constexpr (std::is_same<IdxT, long int>::value)
else if constexpr (std::is_same<index_type, long int>::value)
{
if constexpr (std::is_same<IdxT, double>::value)
if constexpr (std::is_same<index_type, double>::value)
inner_store_float_long_int(row, col, val, scaling, row_indices, col_indices, rows, cols, vals, nnz);
else
inner_store_double_long_int(row, col, val, scaling, row_indices, col_indices, rows, cols, vals, nnz);
Expand All @@ -247,38 +247,38 @@ namespace GridKit
/**
* @brief Enzyme sparse load
*
* @tparam ScalarT - scalar data type
* @tparam IdxT - matrix index data type
* @tparam scalar_type - scalar data type
* @tparam index_type - matrix index data type
*/
template <typename ScalarT, typename IdxT>
__attribute__((always_inline)) static ScalarT sparse_load(IdxT, IdxT, IdxT*, IdxT*, ScalarT*)
template <typename scalar_type, typename index_type>
__attribute__((always_inline)) static scalar_type sparse_load(index_type, index_type, index_type*, index_type*, scalar_type*)
{
return 0.0;
}

/**
* @brief Enzyme identity store
*
* @tparam ScalarT - scalar data type
* @tparam IdxT - matrix index data type
* @tparam scalar_type - scalar data type
* @tparam index_type - matrix index data type
*/
template <typename ScalarT, typename IdxT>
__attribute__((always_inline)) static void ident_store(ScalarT, IdxT, IdxT)
template <typename scalar_type, typename index_type>
__attribute__((always_inline)) static void ident_store(scalar_type, index_type, index_type)
{
assert(0 && "should never store");
}

/**
* @brief Enzyme identity load
*
* @tparam ScalarT - scalar data type
* @tparam IdxT - matrix index data type
* @tparam scalar_type - scalar data type
* @tparam index_type - matrix index data type
*/
template <typename ScalarT, typename IdxT>
__attribute__((always_inline)) static ScalarT ident_load(IdxT row, IdxT col)
template <typename scalar_type, typename index_type>
__attribute__((always_inline)) static scalar_type ident_load(index_type row, index_type col)
{
row /= sizeof(ScalarT);
return (ScalarT) (row == col);
row /= sizeof(scalar_type);
return (scalar_type) (row == col);
}
} // namespace Sparse
} // namespace Enzyme
Expand Down
Loading