Removed check that broke the build. - #7455
Merged
Merged
Conversation
The check has nothing to do with LGRs. If this problem occurs then it is already there without LGRs and should be checked there. Of course the underlying issue is not adhering to interfaces but that fix would take more time.
blattms
added
the
manual:irrelevant
Member
Author
|
jenkins build this please |
Member
|
should include serial in that trigger to make sure it fixes the problem. |
Member
Author
|
jenkins build this serial please |
bska
approved these changes
Sep 25, 2026
bska
left a comment
bska
left a comment
Member
There was a problem hiding this comment.
Could probably do this a bit more selectively with if constexpr and requires, but this does restore the sequential build so I'll merge this into master now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The check has nothing to do with LGRs. If this problem occurs then it is already there without LGRs and should be checked there.
Of course the underlying issue is not adhering to interfaces but that fix would take more time.
Problem was introduced in #7218 due to my lousy/friendly review. Sorry.