Compositional well water support by GitPaean · Pull Request #7442 · OPM/opm-simulators

GitPaean · 2026-09-23T14:57:42Z

No description provided.

GitPaean · 2026-09-23T14:58:55Z

jenkins build this please

GitPaean · 2026-09-23T16:17:47Z

jenkins build this failure_report please

https://ci.opm-project.org/job/opm-simulators-PR-builder/10733/

Size the mobility and surface-rate data for every active phase. Allow water-enabled reservoirs with gas wells or producers, while rejecting unsupported water injectors until the wellbore equations support them.

Add a wellbore water volume fraction and a water mass-balance row. Include water in connection rates and surface-volume splitting so mobile water production and WRAT control work while the hydrocarbon flash remains unchanged.

Form the Schur-complement contribution to the reservoir matrix, scale it to the volume-specific residual, and apply the residual correction using local connection indices. Extend the equation test to cover nonzero cell indices.

Use the DENSITY surface reference for water, report the final phase split after each accepted time step, and carry wellbore water inventory and pressure across report steps for producers and injectors.

Keep the well equations solvable when the hydrocarbon share vanishes. Initialize water injectors with a full water wellbore and a flash-valid hydrocarbon composition from the connected cell.

Limit composition and pressure changes in each Newton step. If a trial wellbore state cannot be assembled, back off toward the last state that assembled successfully.

Constrain the sum of surface oil and water rates and switch to LRAT when the liquid-rate limit is exceeded under another control.

Add six development decks for OPM/opm-simulators#7442, with shared grid, properties, summary, and reporting includes. Keep the case-specific initial states and schedules in the DATA files. CI will generate reference results.

GitPaean · 2026-09-24T10:43:37Z

jenkins build this opm-tests=7442 failure_report please

I put the 7442 wrongly by mistake.

GitPaean · 2026-09-24T10:46:48Z

jenkins build this opm-tests=1621 failure_report please

the results look expected.

https://ci.opm-project.org/job/opm-simulators-PR-builder/10739/

Add six development decks for OPM/opm-simulators#7442, with shared grid, properties, summary, and reporting includes. Keep the case-specific initial states and schedules in the DATA files. CI will generate reference results.

Copilot

Copilot review overview

🟡 Changes recommended

Injector validation and empty-perforation initialization contain unresolved crash or invalid-state paths.

Get a fresh assessment by requesting another Copilot review.

Review effort: Balanced
Findings: 1 · 1

Open (2)

Guard empty perforations before accessing first connection · New
Reject unsupported oil injector type · New

What changed in this PR

Adds water-phase support to the experimental compositional well model, including water inventory, controls, rates, and coupling.

Changes:

Adds water wellbore state, conservation equations, and WRAT/LRAT controls.
Adds Schur-complement matrix contributions and Newton stabilization.
Adds unit and regression coverage for water wells and injector switching.

File	Description
`tests/test_compwell_equations.cpp`	Tests water-filled well equation handling.
`regressionTests.cmake`	Registers compositional water regressions.
`flowexperimental/comp/wells/SingleCompWellState.hpp`	Stores wellbore water fraction.
`flowexperimental/comp/wells/SingleCompWellState_impl.hpp`	Initializes and preserves water state.
`flowexperimental/comp/wells/CompWellState.hpp`	Extends injector initialization inputs.
`flowexperimental/comp/wells/CompWellState_impl.hpp`	Supplies reservoir composition to injectors.
`flowexperimental/comp/wells/CompWellPrimaryVariables.hpp`	Adds water primary variable and equation.
`flowexperimental/comp/wells/CompWellPrimaryVariables_impl.hpp`	Handles water fraction and damped updates.
`flowexperimental/comp/wells/CompWellModel.hpp`	Enables matrix contributions.
`flowexperimental/comp/wells/CompWellModel_impl.hpp`	Preserves water inventory and refreshes rates.
`flowexperimental/comp/wells/CompWellInterface.hpp`	Exposes surface-rate updates.
`flowexperimental/comp/wells/CompWellInterface_impl.hpp`	Validates supported injector configurations.
`flowexperimental/comp/wells/CompWellEquations.hpp`	Adds scaling, pinning, and extraction APIs.
`flowexperimental/comp/wells/CompWellEquations_impl.hpp`	Implements scaled Schur-complement operations.
`flowexperimental/comp/wells/CompWell.hpp`	Declares water-related well quantities.
`flowexperimental/comp/wells/CompWell_impl.hpp`	Implements water flow, inventory, controls, and reporting.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

GitPaean · 2026-09-24T12:53:16Z

Fixed both Copilot findings in b11d758: guard empty water-injector connections and reject OIL/MULTI injection; the flow_comp build and targeted checks passed.

Copilot

Copilot review overview

🔵 Needs a closer look

The change substantially affects nonlinear well conservation, state persistence, and reservoir Jacobian coupling, warranting final human validation.

Review effort: Balanced
Findings: None

Resolved since last review (2)

Guard empty perforations before accessing first connection
Reject unsupported oil injector type

Reject water injection before indexing the water phase in a model that has no active water phase. This gives an input error instead of an assertion failure or an out-of-bounds write. Reject singular well matrices rather than using an identity inverse in the Schur complement. Refresh the well state after each successful assembly, including a backoff retry, so control switching and reported rates use the current surface split. The end-of-timestep flash is no longer needed. Exercise Schur extraction with nonzero cell indices and residual scales, and check that singular matrices are rejected. Format the changed lines.

GitPaean · 2026-09-24T22:25:13Z

jenkins build this failure_report please

https://ci.opm-project.org/job/opm-simulators-PR-builder/10746/

With a zero total rate a rate control equation has no dependence on the primary variables, so a producer that started a report step on WRAT, or on ORAT/GRAT/LRAT without that phase in the stream, had a singular well matrix.

WELTARG can add a WRAT limit to a producer in a deck without water, and the check then read past the end of the phase rates.

Before the well equations converge the rates come from the initial guess, such as the -1000 m3/day seeded for BHP producers, or pair the latest total rate with the previous surface split. Check the rate limits only once the equations have converged and solve again after a switch. The bhp limits are still checked every iteration.

After the halved steps keep failing, assemble at the last assembled state and stop the well iteration instead of failing the time step. Also back off on the Dune::FMatrixError the AD flash throws for a singular derivative system, which previously aborted the run.

Replace the carry-over loop in initWellState with the existing CompWellState::init(prev_well_state) path, and make copyRuntimeStateFrom carry what the loop did: bhp, water fraction and composition.

A well without open connections at the previous report step never had its composition set, so carrying it over replaced the cell composition with zeros, which became a uniform composition once normalized.

Move the mixing of the flashed hydrocarbons with wellbore water into wellboreContents() next to the other extracted flash helpers, use it for both the explicit and the new wellbore masses, and check its derivatives, including those with respect to the water fraction, against finite differences.

A water injector's surface stream is water alone, so fill its surface split directly instead of flashing the pinned hydrocarbon composition, whose failure could not be escaped. With water alone in the wellbore every flash derivative is multiplied by zero, so use the scalar wellbore flash there.

Only C carries the reservoir residual's 1/volume factor, so apply it when filling C instead of keeping per-connection scales in CompWellEquations. apply() and extract() go back to plain C^T D^-1.

flow_comp registers --dwell-fraction-max and --dbhp-max-rel with the black-oil model parameters, but the compositional wells used hardcoded copies of their defaults. flowexp_comp does not register them, so it keeps the defaults.

update_injector_targets() rejects unsupported injectors before any well is created, so the checks in the CompWellInterface constructor never fire. Dispatch on the injector type once there, and update comments that no longer match the primary variable layout or the singular matrix handling.

GitPaean · 2026-09-25T12:47:17Z

jenkins build this failure_report please

https://ci.opm-project.org/job/opm-simulators-PR-builder/10752/

Before this PR an OIL injector took its stream from WINJGAS like a gas injector. Keep that instead of rejecting it, and report the injected rate as oil rather than gas.

GitPaean added the manual:irrelevant This PR is a minor fix and should not appear in the manual label Sep 23, 2026

GitPaean force-pushed the comp-well-water-support branch from e88cb4d to 7f932b0 Compare September 24, 2026 08:15

GitPaean added 7 commits September 24, 2026 11:38

CompWell: prepare compositional wells for active water

56862fa

Size the mobility and surface-rate data for every active phase. Allow water-enabled reservoirs with gas wells or producers, while rejecting unsupported water injectors until the wellbore equations support them.

CompWell: carry water through the wellbore equations

b00973e

Add a wellbore water volume fraction and a water mass-balance row. Include water in connection rates and surface-volume splitting so mobile water production and WRAT control work while the hydrocarbon flash remains unchanged.

CompWell: couple well equations to the reservoir Jacobian

fdfb29f

Form the Schur-complement contribution to the reservoir matrix, scale it to the volume-specific residual, and apply the residual correction using local connection indices. Extend the equation test to cover nonzero cell indices.

CompWell: conserve and report water across time steps

74e2ed5

Use the DENSITY surface reference for water, report the final phase split after each accepted time step, and carry wellbore water inventory and pressure across report steps for producers and injectors.

CompWell: support water-only wellbores and water injectors

333ef4d

Keep the well equations solvable when the hydrocarbon share vanishes. Initialize water injectors with a full water wellbore and a flash-valid hydrocarbon composition from the connected cell.

CompWell: stabilize wellbore Newton updates

b0d9671

Limit composition and pressure changes in each Newton step. If a trial wellbore state cannot be assembled, back off toward the last state that assembled successfully.

CompWell: support LRAT producer control

3be4912

Constrain the sum of surface oil and water rates and switch to LRAT when the liquid-rate limit is exceeded under another control.

GitPaean force-pushed the comp-well-water-support branch from 613aca6 to 3be4912 Compare September 24, 2026 09:39

Register compositional single-connection well regressions

3d31e68

GitPaean mentioned this pull request Sep 24, 2026

compositional cases for wells (single connection) with water OPM/opm-tests#1621

Merged

GitPaean requested a balanced review from Copilot September 24, 2026 11:44

Copilot started reviewing on behalf of GitPaean September 24, 2026 11:45 View session

Copilot AI reviewed Sep 24, 2026

View reviewed changes

Comment thread flowexperimental/comp/wells/SingleCompWellState_impl.hpp Outdated

Comment thread flowexperimental/comp/wells/CompWellInterface_impl.hpp Outdated

CompWell: guard empty injector connections and unsupported types

b11d758

GitPaean requested a balanced review from Copilot September 24, 2026 13:06

Copilot started reviewing on behalf of GitPaean September 24, 2026 13:07 View session

Copilot AI reviewed Sep 24, 2026

View reviewed changes

GitPaean added 2 commits September 24, 2026 23:23

CompWell: preserve hydrocarbon inventory across report steps

4d42ac6

GitPaean force-pushed the comp-well-water-support branch from 138433d to 415eebf Compare September 24, 2026 22:21

GitPaean added 13 commits September 25, 2026 11:24

CompWell: start rate-controlled producers at their target

9b1963a

With a zero total rate a rate control equation has no dependence on the primary variables, so a producer that started a report step on WRAT, or on ORAT/GRAT/LRAT without that phase in the stream, had a singular well matrix.

CompWell: skip the WRAT limit check without a water phase

680a2a7

WELTARG can add a WRAT limit to a producer in a deck without water, and the check then read past the end of the phase rates.

CompWell: carry the wellbore inventory through prev_well_state

c6c1e7c

Replace the carry-over loop in initWellState with the existing CompWellState::init(prev_well_state) path, and make copyRuntimeStateFrom carry what the loop did: bhp, water fraction and composition.

CompWell: carry no state from wells without well equations

5d55d51

A well without open connections at the previous report step never had its composition set, so carrying it over replaced the cell composition with zeros, which became a uniform composition once normalized.

CompWell: scale the well coupling where C is assembled

e5c1d17

Only C carries the reservoir residual's 1/volume factor, so apply it when filling C instead of keeping per-connection scales in CompWellEquations. apply() and extract() go back to plain C^T D^-1.

Tighten the tolerance of the compositional water well regressions

3fe9a03

CompWell: format the changed lines

5b1cbee

CompWell: keep supporting oil injectors

adbcbd6

Before this PR an OIL injector took its stream from WINJGAS like a gas injector. Keep that instead of rejecting it, and report the injected rate as oil rather than gas.

Navigation Menu

Compositional well water support - #7442

Compositional well water support#7442
GitPaean wants to merge 25 commits into
OPM:masterfrom
GitPaean:comp-well-water-support

GitPaean commented Sep 23, 2026

Uh oh!

GitPaean commented Sep 23, 2026

Uh oh!

GitPaean commented Sep 23, 2026 •

edited

Loading

Uh oh!

GitPaean commented Sep 24, 2026 •

edited

Loading

Uh oh!

GitPaean commented Sep 24, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

GitPaean commented Sep 24, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

GitPaean commented Sep 24, 2026 •

edited

Loading

Uh oh!

GitPaean commented Sep 25, 2026 •

edited

Loading

Uh oh!

This branch has not been deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

GitPaean commented Sep 23, 2026

Uh oh!

GitPaean commented Sep 23, 2026

Uh oh!

GitPaean commented Sep 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

GitPaean commented Sep 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

GitPaean commented Sep 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

🟡 Changes recommended

Uh oh!

Uh oh!

Uh oh!

GitPaean commented Sep 24, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

🔵 Needs a closer look

Uh oh!

GitPaean commented Sep 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

GitPaean commented Sep 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This branch has not been deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

GitPaean commented Sep 23, 2026 •

edited

Loading

GitPaean commented Sep 24, 2026 •

edited

Loading

GitPaean commented Sep 24, 2026 •

edited

Loading

GitPaean commented Sep 24, 2026 •

edited

Loading

GitPaean commented Sep 25, 2026 •

edited

Loading