Conversation
svenn-t
added
the
manual:irrelevant
svenn-t
force-pushed
the
pvt_multicomp_salt
branch
from
May 19, 2026 12:22
235b3cb to
dfe334d
Compare
svenn-t
force-pushed
the
pvt_multicomp_salt
branch
from
June 26, 2026 10:52
dfe334d to
955b272
Compare
svenn-t
force-pushed
the
pvt_multicomp_salt
branch
from
August 20, 2026 08:33
955b272 to
df846ba
Compare
svenn-t
force-pushed
the
pvt_multicomp_salt
branch
2 times, most recently
from
September 8, 2026 14:01
655be79 to
8761906
Compare
svenn-t
force-pushed
the
pvt_multicomp_salt
branch
2 times, most recently
from
September 18, 2026 09:09
1b0c350 to
6b4cdcb
Compare
svenn-t
changed the title
Contributor
Author
|
Companion PR is ready-to-review, along with this one. |
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Initialize the salinity vector before indexing it.
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: 1
Open (1)
What changed in this PR
Updates GPU PVT tests to exercise multicomponent Na/Cl salt arrays for CO2STORE.
Changes:
- Adds
SaltArraysupport. - Replaces scalar salinity inputs with Na/Cl component arrays in both tests.
| File | Summary |
|---|---|
tests/gpuistl/test_gpuPvt.cu |
Configures multicomponent salinity data; empty-vector accesses at lines 265 and 290 cause undefined behavior. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| // Test case evaluating pvt values for BrineDynamic on a GPU and CPU | ||
| BOOST_FIXTURE_TEST_CASE(TestCo2GasPvt, Fixture) { | ||
| std::vector<double> salinities = {0.2, 0.3, 0.4}; | ||
| std::vector<Opm::SaltArray<double, Opm::SaltMassFraction> > salinities; |
svenn-t
force-pushed
the
pvt_multicomp_salt
branch
from
September 21, 2026 06:48
6b4cdcb to
2cba5e7
Compare
svenn-t
force-pushed
the
pvt_multicomp_salt
branch
from
September 25, 2026 12:48
2cba5e7 to
ba5468d
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Companion PR to OPM/opm-common#5159 to test and benchmark CO2STORE with multicomponent salts.