Skip to content

fix(security): resolve open Dependabot alerts for seroval and minimatch - #598

Merged
smitt14ua merged 1 commit into
mainfrom
fix/dependabot-seroval-minimatch
Nov 4, 2026
Merged

smitt14ua merged 1 commit into
mainfrom
fix/dependabot-seroval-minimatch

Conversation

@smitt14ua

@smitt14ua smitt14ua commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

Resolves the three open Dependabot alerts in ui/package-lock.json:

  • Dependabot alert 98 (medium): seroval 1.6.9, script injection through RegExp sources in serialized output
  • Dependabot alert 99 (medium): seroval 1.6.9, code injection through a typed array's own constructor property
  • Dependabot alert 100 (medium): minimatch 10.2.6, DoS via globparts amplification

Changes

  • seroval 1.6.9 → 1.6.12: bump solid-js to ^1.9.18, which itself requires seroval ~1.6.11. seroval ships in the client bundle via solid-js.
  • minimatch 10.2.6 → 11.0.4: pinned via overrides, like the other transitive pins from fix(security): resolve all Dependabot alerts incl. maplibre-gl critical XSS #581. eslint and typescript-eslint still declare minimatch ^10 and there is no patched 10.x. minimatch is only used by dev tooling, not the bundle.

Verification

  • npm audit: 0 vulnerabilities
  • eslint src: output identical to main (same two pre-existing warnings), so eslint works with minimatch 11
  • tsc --noEmit: clean
  • vitest run: 2306 passed
  • vite build: ok

@smitt14ua
smitt14ua requested a review from fank November 4, 2026 02:31
@fank

fank commented Nov 4, 2026 •

Copy link
Copy Markdown
Member

Ratatoskr reviewed this pull request.

The review of 300db605 finished without posting anything.

Finished 2026-11-04 02:34 UTC.

- seroval 1.6.9 -> 1.6.12 (Dependabot alerts 98 and 99: script injection
  through RegExp sources, code injection through a typed array's
  constructor property), via solid-js ^1.9.18, which requires
  seroval ~1.6.11.
- minimatch 10.2.6 -> 11.0.4 (Dependabot alert 100: DoS via globparts
  amplification), pinned through overrides: eslint and typescript-eslint
  still ask for ^10 and there is no patched 10.x. Dev tooling only.

npm audit: 0 vulnerabilities. eslint output unchanged, tsc clean,
vitest 2306 passed, vite build ok.
@smitt14ua
smitt14ua force-pushed the fix/dependabot-seroval-minimatch branch from 300db60 to e58d7ef Compare November 4, 2026 02:33
@fank

fank commented Nov 4, 2026 •

Copy link
Copy Markdown
Member

Ratatoskr reviewed this pull request.

Approved on e58d7efa. See the review.

Finished 2026-11-04 02:36 UTC.

@github-actions

github-actions Bot commented Nov 4, 2026

Copy link
Copy Markdown

Coverage Report for ui

Status Category Percentage Covered / Total
🔵 Lines 97.3%
🟰 ±0 pp
10069 / 10348
🔵 Statements 95.61%
🟰 ±0 pp
14078 / 14724
🔵 Functions 95.45%
🟰 ±0 pp
3986 / 4176
🔵 Branches 85.02%
🟰 ±0 pp
5303 / 6237
File CoverageNo changed files found.
Generated in workflow #271 for commit e58d7ef by the Vitest Coverage Report Action

@fank fank left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

APPROVE — 0 blocking findings.

Review details

Reviewed e58d7efab9c777183133a448f59d351f588f46b3 against the base. No actionable correctness or safety defects found. The minimatch override is compatible with the repository's Node >=24 requirement and the exercised ESLint consumers; the installed tree has a single patched seroval version and the intended minimatch override.

Verification on Node 24.21.0, in a temporary copy to leave the reviewed checkout unchanged:

  • npm ci --ignore-scripts: passed; manifest and lockfile agree.
  • ./node_modules/.bin/eslint src: passed, with two unused-variable warnings in PlayerProfileCard.tsx and profileDiff.ts.
  • ./node_modules/.bin/tsc --noEmit: passed.
  • npm test: 2306 passed, 13 skipped (116 test files passed, 1 skipped); jsdom emitted unsupported canvas/scrollTo messages.
  • npm run build: passed, with a chunk-size warning.
  • npm ls minimatch seroval solid-js: passed; resolved minimatch 11.0.4, seroval 1.6.12 and solid-js 1.9.18.
  • npm audit: 0 vulnerabilities.

These are compatibility checks, not dedicated exploit regression tests. No browser/E2E or Go tests were run locally for this dependency-only change. GitHub UI check passed; Go check was still running at the final check and remains subject to required CI gates.

Discussions: GraphQL enumeration returned no review threads (no further pages); none required replies or resolution. Authenticated reviewer identity was verified as fank. PR head was rechecked and still matched the reviewed commit before publication.

@smitt14ua
smitt14ua merged commit 09268b9 into main Nov 4, 2026
3 checks passed
@smitt14ua
smitt14ua deleted the fix/dependabot-seroval-minimatch branch November 4, 2026 02:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants