Repository navigation
fix(security): resolve open Dependabot alerts for seroval and minimatch - #598
Conversation
|
Ratatoskr reviewed this pull request. The review of Finished 2026-11-04 02:34 UTC. |
- seroval 1.6.9 -> 1.6.12 (Dependabot alerts 98 and 99: script injection through RegExp sources, code injection through a typed array's constructor property), via solid-js ^1.9.18, which requires seroval ~1.6.11. - minimatch 10.2.6 -> 11.0.4 (Dependabot alert 100: DoS via globparts amplification), pinned through overrides: eslint and typescript-eslint still ask for ^10 and there is no patched 10.x. Dev tooling only. npm audit: 0 vulnerabilities. eslint output unchanged, tsc clean, vitest 2306 passed, vite build ok.
300db60 to
e58d7ef
Compare
|
Ratatoskr reviewed this pull request. Approved on Finished 2026-11-04 02:36 UTC. |
Coverage Report for ui
File CoverageNo changed files found. |
fank
left a comment
There was a problem hiding this comment.
APPROVE — 0 blocking findings.
Review details
Reviewed e58d7efab9c777183133a448f59d351f588f46b3 against the base. No actionable correctness or safety defects found. The minimatch override is compatible with the repository's Node >=24 requirement and the exercised ESLint consumers; the installed tree has a single patched seroval version and the intended minimatch override.
Verification on Node 24.21.0, in a temporary copy to leave the reviewed checkout unchanged:
npm ci --ignore-scripts: passed; manifest and lockfile agree../node_modules/.bin/eslint src: passed, with two unused-variable warnings in PlayerProfileCard.tsx and profileDiff.ts../node_modules/.bin/tsc --noEmit: passed.npm test: 2306 passed, 13 skipped (116 test files passed, 1 skipped); jsdom emitted unsupported canvas/scrollTo messages.npm run build: passed, with a chunk-size warning.npm ls minimatch seroval solid-js: passed; resolved minimatch 11.0.4, seroval 1.6.12 and solid-js 1.9.18.npm audit: 0 vulnerabilities.
These are compatibility checks, not dedicated exploit regression tests. No browser/E2E or Go tests were run locally for this dependency-only change. GitHub UI check passed; Go check was still running at the final check and remains subject to required CI gates.
Discussions: GraphQL enumeration returned no review threads (no further pages); none required replies or resolution. Authenticated reviewer identity was verified as fank. PR head was rechecked and still matched the reviewed commit before publication.
Resolves the three open Dependabot alerts in
ui/package-lock.json:Changes
solid-jsto^1.9.18, which itself requiresseroval ~1.6.11. seroval ships in the client bundle via solid-js.overrides, like the other transitive pins from fix(security): resolve all Dependabot alerts incl. maplibre-gl critical XSS #581. eslint and typescript-eslint still declareminimatch ^10and there is no patched 10.x. minimatch is only used by dev tooling, not the bundle.Verification
npm audit: 0 vulnerabilitieseslint src: output identical tomain(same two pre-existing warnings), so eslint works with minimatch 11tsc --noEmit: cleanvitest run: 2306 passedvite build: ok