[PERF] api_log_mail: Faster attachment deletion#618
Merged
OCA-git-bot merged 1 commit intoJun 29, 2026
Conversation
When deleting an `ir.attachment`, all the foreing keys are inspected: if the `api.log` has a lot of records this could be very slow. In our instance there are 2 million records and deleting a record takes ~500ms, after this change the same deletion takes less than 1ms.
Contributor
|
This PR has the |
Contributor
Author
|
/ocabot merge patch |
Contributor
|
Hey, thanks for contributing! Proceeding to merge this for you. |
Contributor
|
Congratulations, your PR was merged at 80a9f41. Thanks a lot for contributing to OCA. ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When deleting an
ir.attachment, all the foreing keys are inspected: if theapi.loghas a lot of records this could be very slow.In our instance there are 2 million records and deleting a record takes ~500ms, after this change the same deletion takes less than 1ms.
Note that this change is not needed in future versions because in
17.0the main attachment is moved to the dedicated mixinmail.thread.main.attachment(see odoo/odoo@f8c7f2e).