Skip to content

[18.0] [MIG] project_group_hr_timesheet: Migration to 18.0#1694

Open
luisDIXMIT wants to merge 6 commits intoOCA:18.0from
dixmit:18.0-mig-projec_group_hr_timesheet
Open

[18.0] [MIG] project_group_hr_timesheet: Migration to 18.0#1694
luisDIXMIT wants to merge 6 commits intoOCA:18.0from
dixmit:18.0-mig-projec_group_hr_timesheet

Conversation

@luisDIXMIT
Copy link
Copy Markdown

Standard migration.

@etobella

Copy link
Copy Markdown
Member

@etobella etobella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file shouldn't have gone with the commit? 7209089

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file shouldn't have gone with the commit? 7209089

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @CristianoMafraJunior, I don’t fully understand your question.. That commit comes from a pre-commit run, so it contains automatic fixes. Do you mean that I should remove the commit?

Copy link
Copy Markdown
Contributor

@BhaveshHeliconia BhaveshHeliconia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review LGTM!

@OCA-git-bot
Copy link
Copy Markdown
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants