[19.0][IMP] mail_tracking: Add email score search functionality (fw port)#220
[19.0][IMP] mail_tracking: Add email score search functionality (fw port)#220tarteo wants to merge 1 commit into
Conversation
|
|
||
| mail, tracking = self.mail_send(self.recipient_1.email) | ||
| tracking.event_create("reject", {}) | ||
|
|
There was a problem hiding this comment.
As you are putting already a comment line, adding an extra empty line forces a lot of vertical scroll for reading the code, so it's convenient to remove such extra empty lines IMO.
There was a problem hiding this comment.
It's also a question of following the current code style.
There was a problem hiding this comment.
I can remove them for you. But I like spacing between blocks comment, for me it's faster to see what the comment is about. We should decide in the OCA what style is preferred, and then enforce it using linting if possible.
There was a problem hiding this comment.
Thanks for considering my comment. For me, the syntax highlighting already acts for that visual distinction, so no need to add that extra lines, and more lines fits in the same screen size.
fw port from 18.0: 06818b7
tarteo
force-pushed
the
19-fw-18-red-score
branch
from
05eab17 to
7a15fb5
Compare
3 participants
fw port of #204