[19.0][MIG] mail_attach_existing_attachment_account: Migration to 19.0 #211
Conversation
[UPD] README.rst [ADD] icon.png [UPD] Update mail_attach_existing_attachment_account.pot [UPD] README.rst
TT28899 [UPD] Update mail_attach_existing_attachment_account.pot [UPD] README.rst
…ti-company Doing a bulk search on accounts without company filter can lead to selecting an account of other company, and thus, making the test to fail. We restrict the account search to the current company.
We show the field with the same technique as in the base module, which improves the display, showing the label.
Added test cases Revert changes made for tests Updated tests Updated tests Updated tests
OCA-git-bot
added
series:19.0
mod:mail_attach_existing_attachment_account
chienandalu
force-pushed
the
19.0-mig-mail_attach_existing_attachment_account
branch
from
6f66e0b to
87b1ac6
Compare
fcvalgar
left a comment
fcvalgar
left a comment
There was a problem hiding this comment.
Great work, thank you for the migration @chienandalu .
I reviewed the module in 19.0 and tested the attachment selection flow from the invoice sending wizard. The following tests were performed:
Test 1: OK - Automatic installation. The module was correctly installed when its dependencies were present.
Test 2: OK - Existing attachment on an invoice. A PDF attached to a customer invoice was available for selection in the invoice sending wizard.
Test 3: OK - Sending an invoice with an existing attachment selected. The invoice email was sent correctly and included the selected existing attachment.
Test 4: OK - Invoice without existing attachments. The sending wizard opened correctly and the standard invoice sending flow was not affected.
Test 5: OK - Multiple attachments on the same invoice. Several supported attachments could be selected and included in the invoice email.
Test 6: OK - Attachment type handling. Supported attachment types were available for selection, while unsupported or non-eligible attachments were not incorrectly included.
Test 7: OK - Standard sending without selecting existing attachments. The invoice was sent correctly without adding extra attachments when none were selected.
Everything worked as expected, so I approve this PR.
|
please review @yajo |
chienandalu
force-pushed
the
19.0-mig-mail_attach_existing_attachment_account
branch
from
87b1ac6 to
a5233de
Compare
|
Hey, thanks for contributing! Proceeding to merge this for you. |
|
Congratulations, your PR was merged at d57490e. Thanks a lot for contributing to OCA. ❤️ |
12 participants
please review @fcvalgar
superseds #174
cc @moduon