[19.0][IMP] contract_payment_mode: hide Payment Mode by default in the contract list - #1518
Open
bosd wants to merge 1 commit into
Open
[19.0][IMP] contract_payment_mode: hide Payment Mode by default in the contract list#1518bosd wants to merge 1 commit into
bosd wants to merge 1 commit into
Conversation
…ract list The column carried no `optional` attribute, so it sat outside Odoo's column selector and every database that installs this module got it added to the contract list permanently, with no way to switch it off. Put it under the selector with `optional="hide"`. The payment mode is a detail of how a contract is billed rather than something you scan a list for, and a glue module should not spend a list column by default. Users who want it turn it on from the column selector, and the choice is remembered per user. The form and search views keep the field as they are.
OCA-git-bot
added
series:19.0
mod:contract_payment_mode
pedrobaeza
reviewed
Sep 5, 2026
pedrobaeza
left a comment
pedrobaeza
left a comment
Member
There was a problem hiding this comment.
OK to be optional, but I think it should be optional="show" to keep it as it was before.
Contributor
Author
|
Actually wanted to unify the contract view with the invoice view |
pedrobaeza
approved these changes
Sep 5, 2026
pedrobaeza
left a comment
pedrobaeza
left a comment
Member
There was a problem hiding this comment.
OK, you have convinced me.
bofiltd
approved these changes
Sep 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Spotted on the 19.0 runboat, alongside #1517 - same problem, different module.
Problem
This module adds Payment Mode to the contract list without an
optionalattribute:Without
optional, the column sits outside Odoo's column selector. Every database that installs this glue module gets it added to the contract list permanently, with no way to switch it off.Change
optional="hide"on the list column.The payment mode is a detail of how a contract is billed rather than something you scan a list for, and a glue module should not spend a list column by default. Users who want it turn it on from the column selector, and the choice is remembered per user.
The form and search views keep the field exactly as they are.