[19.0][IMP] contract: notify when there is nothing to invoice - #1510
Draft
bosd wants to merge 1 commit into
Draft
Conversation
The "Create invoices" button on a contract stays visible while the contract has nothing left to invoice (e.g. all its lines are canceled). In that case clicking it silently did nothing, leaving the user wondering whether the action failed. Add `action_recurring_create_invoice`, used by the button, which falls back to a warning notification when `recurring_create_invoice` did not create any invoice.
bosd
marked this pull request as draft
September 2, 2026 15:34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Create invoices button on a contract form stays visible while the contract has nothing left to invoice (for instance when all of its lines are canceled, so
create_invoice_visibilityis still true but no line can be invoiced).Clicking it in that situation silently did nothing: no invoice, no message, no error. Users reasonably assume the action failed.
This PR adds
action_recurring_create_invoice, which the button now calls. It delegates torecurring_create_invoiceand, when no invoice was created, returns adisplay_notificationwarning ("Nothing to invoice") in the top right corner instead of returning nothing.recurring_create_invoiceitself is left untouched, so modules inheriting or calling it keep their current behaviour.Covered by two new tests in
contract/tests/test_contract.py.