Repository navigation
fix(tao): stopping a touchpad glide no longer flings the content on - #896
Merged
Merged
Conversation
…nt on A DirectManipulation glide closed with MOMENTUM_ENDED, an immediate PanEnd. Compose flings at PanEnd with the velocity of the last steps, so fingers put down to stop a fast glide (INERTIA -> RUNNING) threw the content another half-glide. The glide now closes with a deferred ENDED: the PanEnd lands past Compose's velocity horizon, and fingers that move again continue the pan.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
-Dnucleus.tao.directManipulation=falseworked around it).INERTIA → RUNNING) closed the pan withMOMENTUM_ENDED, i.e. an immediatePanEnd. Compose'sTrackpadScrollingLogicflings atPanEndwith the velocity of the last steps — the glide's — so the content flew on under resting fingers.TaoDirectManipulationGesturecloses a glide with a deferredENDED(the router's grace). ThePanEndlands past Compose's 40 ms velocity horizon, and fingers that move again within the grace continue the same pan. The router shared with macOS is untouched.Test plan
fingers put down on a fast glide stop the column where it is— fails without the fix (447 → 681 px), passes with itTaoDirectManipulationGestureTest+ seeded-walk oracle updated for the new phase sequence:decorated-window-tao:test,detekt,ktlintCheck#706suite on Windows: 8/8 functional cases; the monkey failed once on seed+0 at first, did not reproduce in 5 later runs with the fix (nor 3 without)