Skip to content

[GRE-136] Add an edge from a node - #303

Merged
c3c43083 merged 6 commits into
mainfrom
gre-136
Nov 19, 2026
Merged

c3c43083 merged 6 commits into
mainfrom
gre-136

Conversation

@c3c43083

Copy link
Copy Markdown
Collaborator

No description provided.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Canceling pointerdown suppresses the mouseup event used to finish connection drags, preventing connections from being created and leaving the dragging state uncleared.

4 open issues
What changed in this PR

This PR adds drag-to-connect edges between existing nodes in the dashboard’s blueprint editor. It also introduces API helpers and a model for two-factor approval challenges.

Changes:

  • Add connection handles, drag previews, and callbacks for creating node edges.
  • Reject self-links, links to START nodes, and cycles; update graph successors and roots.
  • Add token generation, validation, approval-link construction, and challenge persistence fields.
File Description
dashboard/​src/​widgets/​BlueprintFlowWidget/​BlueprintFlowWidget.tsx Apply validated connections to graph state.
dashboard/​src/​components/​BlueprintFlow/​NodeConnectionOverlay.tsx Preview node drags and process connection drops.
dashboard/​src/​components/​BlueprintFlow/​helper.ts Validate proposed node connections.
dashboard/​src/​components/​BlueprintFlow/​FlowNodeRenderer.tsx Render connection handles and mark drop targets.
dashboard/​src/​components/​BlueprintFlow/​BlueprintFlowPlugin.styles.tsx Style connection handles and hover visibility.
dashboard/​src/​components/​BlueprintFlow/​BlueprintFlow.types.ts Define the node-connection callback.
dashboard/​src/​components/​BlueprintFlow/​BlueprintFlow.tsx Manage connection drag state and wire callbacks.
api/​src/​models/​TwoFactorChallenge.ts Define stored approval-challenge fields.
api/​src/​lib/​twoFactorToken.ts Generate and verify tokens and build approval links.

Review effort: Balanced

@c3c43083
c3c43083 merged commit 7fb37c4 into main Nov 19, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants