Repository navigation
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Canceling pointerdown suppresses the mouseup event used to finish connection drags, preventing connections from being created and leaving the dragging state uncleared.
4 open issues
What changed in this PR
This PR adds drag-to-connect edges between existing nodes in the dashboard’s blueprint editor. It also introduces API helpers and a model for two-factor approval challenges.
Changes:
- Add connection handles, drag previews, and callbacks for creating node edges.
- Reject self-links, links to START nodes, and cycles; update graph successors and roots.
- Add token generation, validation, approval-link construction, and challenge persistence fields.
| File | Description |
|---|---|
| dashboard/src/widgets/BlueprintFlowWidget/BlueprintFlowWidget.tsx | Apply validated connections to graph state. |
| dashboard/src/components/BlueprintFlow/NodeConnectionOverlay.tsx | Preview node drags and process connection drops. |
| dashboard/src/components/BlueprintFlow/helper.ts | Validate proposed node connections. |
| dashboard/src/components/BlueprintFlow/FlowNodeRenderer.tsx | Render connection handles and mark drop targets. |
| dashboard/src/components/BlueprintFlow/BlueprintFlowPlugin.styles.tsx | Style connection handles and hover visibility. |
| dashboard/src/components/BlueprintFlow/BlueprintFlow.types.ts | Define the node-connection callback. |
| dashboard/src/components/BlueprintFlow/BlueprintFlow.tsx | Manage connection drag state and wire callbacks. |
| api/src/models/TwoFactorChallenge.ts | Define stored approval-challenge fields. |
| api/src/lib/twoFactorToken.ts | Generate and verify tokens and build approval links. |
Review effort: Balanced
ea9b0392
approved these changes
Nov 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


No description provided.