Open
Conversation
wavehassman
requested changes
Apr 13, 2026
Contributor
wavehassman
left a comment
wavehassman
left a comment
There was a problem hiding this comment.
Very small change, great job!
| error: teamTypesError | ||
| } = useAllTeamTypes(); | ||
|
|
||
| if (teamTypesIsLoading || !allTeamTypes) return <LoadingIndicator />; |
Contributor
There was a problem hiding this comment.
put this after the error
Contributor
Author
There was a problem hiding this comment.
Ok should be done!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Added the Division Page for Guests. The Division tab in the sidebar still displays all teams when hovered over but now you can also click on it to go to the Division page. To do this I needed to very slightly change NavLinkPage because before if a tab was an expandable menu it was not clickable. I also implemented a link for users to go back to the divisions page from the Team page.
Notes
I accidentally created a PR from my last branch which I have closed so it shouldn't be an issue just thought I'd mention in it just in case.
Test Cases
Frontend changes only.
Screenshots
To Do
All done!
Checklist
It can be helpful to check the
ChecksandFiles changedtabs.Please review the contributor guide and reach out to your Tech Lead if anything is unclear.
Please request reviewers and ping on slack only after you've gone through this whole checklist.
yarn.lockchanges (unless dependencies have changed)Closes # (issue #)
#4086