removed redundant sabo id formatter

Author: chpy04

src/frontend/src/pages/FinancePage/FinanceComponents/ReimbursementRequestInfo.tsx

@@ -9,7 +9,6 @@ import {
   centsToDollar,
   datePipe,
   dateUndefinedPipe,
-  formatSaboIdPipe
 } from '../../../utils/pipes';
 import {
   createReimbursementRequestRowData,
@@ -161,7 +160,7 @@ const ReimbursementRequestInfo = ({
         headerName: 'SABO ID',
         flex: 0.5,
         minWidth: 100,
-        valueGetter: (params: any) => formatSaboIdPipe(params.row.saboId)
+        valueGetter: (params: any) => params.row.saboId
       },
       {
         field: 'dateSubmitted',

src/frontend/src/pages/FinancePage/ReimbursementRequestDetailPage/ReimbursementRequestDetailsView.tsx

@@ -3,7 +3,7 @@
  * See the LICENSE file in the repository root folder for details.
  */
 
-import { accountCodePipe, displayEnum, formatSaboIdPipe } from '../../../utils/pipes';
+import { accountCodePipe, displayEnum } from '../../../utils/pipes';
 import { Assignment, ChangeCircle, Edit, Pending } from '@mui/icons-material';
 import CheckIcon from '@mui/icons-material/Check';
 import CloseIcon from '@mui/icons-material/Close';
@@ -465,7 +465,7 @@ const ReimbursementRequestDetailsView: React.FC<ReimbursementRequestDetailsViewP
     },
     { content: `$${centsToDollar(reimbursementRequest.totalCost)}` },
     { content: reimbursementRequest.vendor.name },
-    { content: `${formatSaboIdPipe(reimbursementRequest.saboId)}` },
+    { content: `${reimbursementRequest.saboId}` },
     {
       content: refundSourceNames.join(', ')
     },

src/frontend/src/utils/pipes.ts

@@ -210,14 +210,3 @@ export const labelPipe = (label: string) => {
 
   return result;
 };
-
-// Pad SABO ID with leading zeroes
-export const formatSaboIdPipe = (saboId: number | undefined): string => {
-  if (saboId === undefined || saboId === null) return undefinedPipe(saboId as any);
-  const str = String(saboId);
-  // Only pad if it's shorter than 5
-  if (str.length < 5) {
-    return str.padStart(5, '0');
-  }
-  return str;
-};

src/shared/src/types/finance-types.ts

@@ -88,7 +88,7 @@ export interface ReimbursementRequestData {
   totalBudget: number;
   approved: number;
   pendingApproval: number;
-  addedToSabo: number;
+  addedToSabo: string;
   reimbursed: number;
   available: number;
 }

src/shared/src/types/reimbursement-requests-types.ts

@@ -12,7 +12,7 @@ export interface IndexCode {
 export interface ReimbursementRequestRow {
   identifier: number;
   id: string;
-  saboId: number | undefined;
+  saboId: string | undefined;
   amount: number;
   dateSubmitted: Date;
   status: ReimbursementStatusType;
@@ -51,7 +51,7 @@ export interface Receipt {
 export interface ReimbursementRequest {
   reimbursementRequestId: string;
   identifier: number;
-  saboId?: number;
+  saboId?: string;
   dateCreated: Date;
   dateOfExpense?: Date;
   reimbursementStatuses: ReimbursementStatus[];