initial date scheduled back to datetime, misc date bug fixes

chpy04 · chpy04 · commit 939be7c5d2e9 · 2026-02-28T11:54:25.000-05:00
diff --git a/src/backend/src/prisma/migrations/20260228000000_change_date_only_fields_to_db_date/migration.sql b/src/backend/src/prisma/migrations/20260228000000_change_date_only_fields_to_db_date/migration.sql
@@ -11,7 +11,6 @@ ALTER TABLE "Sponsor" ALTER COLUMN "joinDate" SET DATA TYPE date;
 ALTER TABLE "Sponsor_Task" ALTER COLUMN "dueDate" SET DATA TYPE date;
 ALTER TABLE "Sponsor_Task" ALTER COLUMN "notifyDate" SET DATA TYPE date;
 ALTER TABLE "Availability" ALTER COLUMN "dateSet" SET DATA TYPE date;
-ALTER TABLE "Event" ALTER COLUMN "initialDateScheduled" SET DATA TYPE date;
 ALTER TABLE "Milestone" ALTER COLUMN "dateOfEvent" SET DATA TYPE date;
 ALTER TABLE "Graph" ALTER COLUMN "startDate" SET DATA TYPE date;
 ALTER TABLE "Graph" ALTER COLUMN "endDate" SET DATA TYPE date;
diff --git a/src/backend/src/prisma/schema.prisma b/src/backend/src/prisma/schema.prisma
@@ -779,7 +779,7 @@ model Vendor {
   organizationId        String
   organization          Organization            @relation(fields: [organizationId], references: [organizationId])
   username              String?
-  password              String? // password is encrypted  
+  password              String? // password is encrypted
   discountCode          String?
   twoFactorContacts     User[]                  @relation(name: "twoFactorContactVendors")
   notes                 String?
@@ -1088,9 +1088,9 @@ model Event {
   shops                      Shop[]
   machinery                  Machinery[]
   workPackages               Work_Package[]
-  documents                  Document[]      
+  documents                  Document[]
   status                     Event_Status
-  initialDateScheduled       DateTime?       @db.Date
+  initialDateScheduled       DateTime?
   questionDocumentLink       String?
   description                String?
   notificationSlackThreads   Message_Info[]
diff --git a/src/backend/src/utils/slack.utils.ts b/src/backend/src/utils/slack.utils.ts
@@ -437,6 +437,7 @@ export const sendEventScheduledSlackNotif = async (threads: SlackMessageThread[]
   const drName = event.title + (wpNames ? ` (${wpNames})` : '');
 
   // Get the first scheduled time
+  // Fine as temporary fix because only DRs with single slots are sending notifications
   const [firstScheduledTime] = event.scheduledTimes;
   if (!firstScheduledTime) {
     throw new HttpException(400, 'Event has no scheduled times');
diff --git a/src/frontend/src/apis/transformers/calendar.transformer.ts b/src/frontend/src/apis/transformers/calendar.transformer.ts
@@ -16,6 +16,7 @@ export const filterEventTransformer = (event: Event): Event => {
   }
   return {
     ...event,
+    initialDateScheduled: event.initialDateScheduled ? new Date(event.initialDateScheduled) : undefined,
     dateCreated: new Date(event.dateCreated),
     scheduledTimes: event.scheduledTimes.map((schedule) => ({
       ...schedule,
diff --git a/src/frontend/src/apis/transformers/change-requests.transformers.ts b/src/frontend/src/apis/transformers/change-requests.transformers.ts
@@ -5,6 +5,7 @@
 
 import {
   ChangeRequest,
+  dbDateToLocalDate,
   ImplementedChange,
   ProjectProposedChanges,
   StandardChangeRequest,
@@ -23,7 +24,7 @@ const transformWorkPackageProposedChanges = (
 ): WorkPackageProposedChanges => {
   return {
     ...workPackageProposedChanges,
-    startDate: new Date(workPackageProposedChanges.startDate)
+    startDate: dbDateToLocalDate(new Date(workPackageProposedChanges.startDate))
   };
 };
 
@@ -43,7 +44,7 @@ export const changeRequestTransformer = (changeRequest: ChangeRequest | Standard
     dateImplemented: changeRequest.dateImplemented ? new Date(changeRequest.dateImplemented) : changeRequest.dateImplemented
   };
   if (data.startDate) {
-    data.startDate = new Date(data.startDate);
+    data.startDate = dbDateToLocalDate(new Date(data.startDate));
   }
   const output = data;
 
diff --git a/src/frontend/src/apis/transformers/projects.transformers.ts b/src/frontend/src/apis/transformers/projects.transformers.ts
@@ -4,6 +4,7 @@
  */
 
 import {
+  dbDateToLocalDate,
   DescriptionBullet,
   Project,
   ProjectOverview,
@@ -40,8 +41,8 @@ export const projectTransformer = (project: Project): Project => {
   return {
     ...project,
     dateCreated: new Date(project.dateCreated),
-    startDate: project.startDate ? new Date(project.startDate) : undefined,
-    endDate: project.endDate ? new Date(project.endDate) : undefined,
+    startDate: project.startDate ? dbDateToLocalDate(new Date(project.startDate)) : undefined,
+    endDate: project.endDate ? dbDateToLocalDate(new Date(project.endDate)) : undefined,
     workPackages: project.workPackages.map(workPackageTransformer),
     descriptionBullets: project.descriptionBullets.map(descriptionBulletTransformer),
     changes: project.changes.map(implementedChangeTransformer),
diff --git a/src/frontend/src/apis/transformers/tasks.transformers.ts b/src/frontend/src/apis/transformers/tasks.transformers.ts
@@ -1,4 +1,4 @@
-import { Task } from 'shared';
+import { dbDateToLocalDate, Task } from 'shared';
 
 /**
  * Transforms a task to ensure deep field transformation of date objects.
@@ -11,7 +11,7 @@ export const taskTransformer = (task: Task): Task => {
     ...task,
     dateCreated: new Date(task.dateCreated),
     dateDeleted: task.dateDeleted ? new Date(task.dateDeleted) : undefined,
-    deadline: task.deadline ? new Date(task.deadline) : undefined,
-    startDate: task.startDate ? new Date(task.startDate) : undefined
+    deadline: task.deadline ? dbDateToLocalDate(new Date(task.deadline)) : undefined,
+    startDate: task.startDate ? dbDateToLocalDate(new Date(task.startDate)) : undefined
   };
 };
diff --git a/src/frontend/src/apis/transformers/work-packages.transformers.ts b/src/frontend/src/apis/transformers/work-packages.transformers.ts
@@ -3,7 +3,7 @@
  * See the LICENSE file in the repository root folder for details.
  */
 
-import { RetrospectiveWorkPackage, WorkPackage, WorkPackagePreview } from 'shared';
+import { dbDateToLocalDate, RetrospectiveWorkPackage, WorkPackage, WorkPackagePreview } from 'shared';
 import { implementedChangeTransformer } from './change-requests.transformers';
 import { descriptionBulletTransformer } from './projects.transformers';
 import { eventPreviewTransformer } from './calendar.transformer';
@@ -18,8 +18,8 @@ export const workPackageTransformer = (workPackage: WorkPackage): WorkPackage =>
   return {
     ...workPackage,
     dateCreated: new Date(workPackage.dateCreated),
-    startDate: new Date(workPackage.startDate),
-    endDate: new Date(workPackage.endDate),
+    startDate: dbDateToLocalDate(new Date(workPackage.startDate)),
+    endDate: dbDateToLocalDate(new Date(workPackage.endDate)),
     descriptionBullets: workPackage.descriptionBullets.map(descriptionBulletTransformer),
     changes: workPackage.changes.map(implementedChangeTransformer),
     events: workPackage.events.map(eventPreviewTransformer)
@@ -30,14 +30,14 @@ export const retrospectiveWorkPackageTransformer = (workPackage: RetrospectiveWo
   return {
     ...workPackageTransformer(workPackage),
     originalDuration: workPackage.originalDuration,
-    originalStartDate: new Date(workPackage.originalStartDate)
+    originalStartDate: dbDateToLocalDate(new Date(workPackage.originalStartDate))
   };
 };
 
 export const workPackagePreviewTransformer = (workPackage: WorkPackagePreview): WorkPackagePreview => {
   return {
     ...workPackage,
-    startDate: new Date(workPackage.startDate),
-    endDate: new Date(workPackage.endDate)
+    startDate: dbDateToLocalDate(new Date(workPackage.startDate)),
+    endDate: dbDateToLocalDate(new Date(workPackage.endDate))
   };
 };
diff --git a/src/frontend/src/pages/CalendarPage/AvailabilityScheduleView.tsx b/src/frontend/src/pages/CalendarPage/AvailabilityScheduleView.tsx
@@ -31,9 +31,7 @@ const AvailabilityScheduleView: React.FC<AvailabilityScheduleViewProps> = ({
   const totalUsers = usersToAvailabilities.size;
   const [selectedTimeslot, setSelectedTimeslot] = useState<number | null>(null);
   // Use displayDate if provided, otherwise fall back to event's initial date.
-  // initialDateScheduled is @db.Date (midnight UTC) — normalize to local calendar date.
-  const initialDate =
-    displayDate || (event.initialDateScheduled ? dbDateToLocalDate(event.initialDateScheduled) : new Date());
+  const initialDate = displayDate || (event.initialDateScheduled ?? new Date());
   const potentialDays = getNextSevenDays(initialDate);
 
   // Handle hover - updates the sidebar with available/unavailable users and slot info
diff --git a/src/frontend/src/pages/CalendarPage/CalendarWeekView.tsx b/src/frontend/src/pages/CalendarPage/CalendarWeekView.tsx
@@ -203,14 +203,12 @@ const CalendarWeekView: React.FC<CalendarWeekViewProps> = ({
   );
 
   // Build per-day all-day event lists
-  // Unscheduled design reviews have startTime from @db.Date (midnight UTC) — use UTC comparison.
-  // Scheduled all-day events use local time range comparison for multi-day spans.
   const allDayEventsByDay: EventInstance[][] = weekDays.map((day) =>
     allDayEvents.filter((e) => {
       const start = new Date(e.startTime);
       const end = new Date(e.endTime);
       if (start.getTime() === end.getTime()) {
-        // Single-point event (e.g., unscheduled design review from @db.Date) — compare UTC date
+        // Single-point event (e.g., unscheduled design review or all day event) — compare UTC date
         return (
           start.getUTCFullYear() === day.getFullYear() &&
           start.getUTCMonth() === day.getMonth() &&
diff --git a/src/frontend/src/pages/CalendarPage/Components/EventAvailabilityPage.tsx b/src/frontend/src/pages/CalendarPage/Components/EventAvailabilityPage.tsx
@@ -129,8 +129,7 @@ export const EventAvailabilityPage: React.FC = () => {
     if (dateParam) {
       return new Date(dateParam);
     }
-    // initialDateScheduled is @db.Date (midnight UTC) — normalize to local calendar date
-    return event?.initialDateScheduled ? dbDateToLocalDate(event.initialDateScheduled) : new Date();
+    return event?.initialDateScheduled;
   }, [dateParam, event]);
 
   const isUserMember = useMemo(() => {
diff --git a/src/frontend/src/utils/pipes.ts b/src/frontend/src/utils/pipes.ts
@@ -14,10 +14,10 @@ import {
   UserPreview,
   ScheduleSlot,
   Event,
-  formatDateOnly,
   formatEventTime,
   formatEventDate
 } from 'shared';
+import dayjs from 'dayjs';
 
 /**
  * Pipes:
@@ -71,13 +71,14 @@ export const emDashPipe = (str: string) => {
 
 /**
  * Return a given date as a string in the local en-US format.
- * For date-only values (@db.Date columns), uses UTC formatting to preserve the stored calendar date.
+ * @db.Date values should be normalized to local dates via dbDateToLocalDate in transformers
+ * before reaching this function, so local formatting is correct for all inputs.
  */
 export const datePipe = (date?: Date | string, includeYear = true) => {
   if (!date) return '';
   date = typeof date === 'string' ? new Date(date) : date;
   const format = includeYear ? 'MM/DD/YYYY' : 'MM/DD';
-  return formatDateOnly(date, format);
+  return dayjs(date).format(format);
 };
 
 /** returns a given number as a string with a percent sign */
@@ -137,7 +138,7 @@ export const eventNamePipe = (event: Event) => {
 };
 
 export const dateRangePipe = (startDate: Date, endDate: Date) => {
-  return `${formatDateOnly(startDate, 'M/D')} - ${formatDateOnly(endDate, 'M/D')}`;
+  return `${dayjs(startDate).format('M/D')} - ${dayjs(endDate).format('M/D')}`;
 };
 
 export const undefinedPipe = (element: any) => {
diff --git a/src/shared/src/backend-supports/projects-get-all.ts b/src/shared/src/backend-supports/projects-get-all.ts
@@ -13,7 +13,7 @@ interface WorkPackageDurationProps {
 
 const calculateEndDate = (start: Date, weeks: number) => {
   const end = new Date(start);
-  end.setDate(start.getUTCDate() + weeks * 7);
+  end.setUTCDate(start.getUTCDate() + weeks * 7);
   return end;
 };
 
diff --git a/src/shared/src/date-utils.ts b/src/shared/src/date-utils.ts
@@ -20,9 +20,7 @@ const addWeeksToDate = (start: Date, weeks: number) => addDaysToDate(start, week
  * @returns the outcome of adding the days to the start date
  */
 const addDaysToDate = (start: Date, days: number) => {
-  const end = new Date(start);
-  end.setDate(start.getDate() + days);
-  return end;
+  return new Date(start.getTime() + days * 24 * 60 * 60 * 1000);
 };
 
 /**

Original file line number	Diff line number	Diff line change
`@@ -16,6 +16,7 @@ export const filterEventTransformer = (event: Event): Event => {`
`16`	`16`	`}`
`17`	`17`	`return {`
`18`	`18`	`...event,`
	`19`	`+ initialDateScheduled: event.initialDateScheduled ? new Date(event.initialDateScheduled) : undefined,`
`19`	`20`	`dateCreated: new Date(event.dateCreated),`
`20`	`21`	`scheduledTimes: event.scheduledTimes.map((schedule) => ({`
`21`	`22`	`...schedule,`