operations on date objects use utc

chpy04 · chpy04 · commit fff9eb40a3f1 · 2026-02-28T09:05:33.000-05:00
diff --git a/src/backend/src/services/notifications.services.ts b/src/backend/src/services/notifications.services.ts
@@ -197,9 +197,9 @@ export default class NotificationsService {
           const workPackageNames = event.workPackages.map((wp) => wp.wbsElement.name).join(', ');
 
           // Get the earliest scheduled start time for display
-          const earliestSlot = event.scheduledTimes
+          const [earliestSlot] = event.scheduledTimes
             .filter((slot) => slot.startTime)
-            .sort((a, b) => new Date(a.startTime!).getTime() - new Date(b.startTime!).getTime())[0];
+            .sort((a, b) => new Date(a.startTime!).getTime() - new Date(b.startTime!).getTime());
           const timeDisplay = earliestSlot ? formatTimeForSlack(new Date(earliestSlot.startTime!)) : 'TBD';
 
           return (
diff --git a/src/backend/src/utils/change-requests.utils.ts b/src/backend/src/utils/change-requests.utils.ts
@@ -105,11 +105,7 @@ export const updateBlocking = async (
     const change = {
       changeRequestId: crId,
       implementerId: reviewer.userId,
-      detail: buildChangeDetail(
-        'Start Date',
-        formatDateOnly(currWbs.workPackage.startDate),
-        formatDateOnly(newStartDate)
-      )
+      detail: buildChangeDetail('Start Date', formatDateOnly(currWbs.workPackage.startDate), formatDateOnly(newStartDate))
     };
 
     await prisma.work_Package.update({
diff --git a/src/backend/src/utils/slack.utils.ts b/src/backend/src/utils/slack.utils.ts
@@ -7,9 +7,7 @@ import {
   CreateSponsorTask,
   User,
   Event,
-  formatForSlack,
-  formatDateForSlack,
-  formatTimeForSlack
+  formatForSlack
 } from 'shared';
 import { Account_Code, Reimbursement_Product_Other_Reason, Sponsor_Task } from '@prisma/client';
 import {
diff --git a/src/backend/tests/unit/finance.test.ts b/src/backend/tests/unit/finance.test.ts
@@ -67,7 +67,7 @@ describe('Finance Tests', () => {
       expect(result.name).toEqual('Google');
       expect(result.activeStatus).toBe(true);
       expect(result.sponsorValue).toBe(5000);
-      expect(result.joinDate).toEqual(new Date(12, 1, 24));
+      expect(result.joinDate).toEqual(new Date(Date.UTC(12, 1, 24)));
       expect(result.activeYears).toEqual([2024, 2025]);
       expect(result.tier.sponsorTierId).toEqual(sponsorTierId);
       expect(result.taxExempt).toBe(true);
@@ -228,8 +228,8 @@ describe('Finance Tests', () => {
       );
 
       expect(newSponsorTask.notes).toEqual('newNotes');
-      expect(newSponsorTask.dueDate).toEqual(new Date(12, 10, 24));
-      expect(newSponsorTask.notifyDate).toEqual(new Date(12, 20, 24));
+      expect(newSponsorTask.dueDate).toEqual(new Date(Date.UTC(12, 10, 24)));
+      expect(newSponsorTask.notifyDate).toEqual(new Date(Date.UTC(12, 20, 24)));
       expect(newSponsorTask.assigneeUserId).toEqual(user.userId);
     });
     it('Edit fails with non head user trying to edit', async () => {
@@ -459,7 +459,7 @@ describe('Finance Tests', () => {
 
       expect(result.assignee?.userId).toEqual(user.userId);
       expect(result.notes).toEqual('hello notes');
-      expect(result.dueDate).toEqual(new Date(1, 2, 3));
+      expect(result.dueDate).toEqual(new Date(Date.UTC(1, 2, 3)));
       expect(result.assignee?.userId).toEqual(user.userId);
     });
   });
@@ -529,7 +529,7 @@ describe('Finance Tests', () => {
       expect(updatedSponsor.name).toBe('newName');
       expect(updatedSponsor.activeStatus).toBe(false);
       expect(updatedSponsor.sponsorValue).toBe(4000);
-      expect(updatedSponsor.joinDate).toEqual(new Date(5, 11, 25));
+      expect(updatedSponsor.joinDate).toEqual(new Date(Date.UTC(5, 11, 25)));
       expect(updatedSponsor.activeYears).toEqual([2024, 2025]);
       expect(updatedSponsor.tier.sponsorTierId).toBe(sponsorTierId);
       expect(updatedSponsor.sponsorContact).toBe('New Vendor Contact');
diff --git a/src/backend/tests/unit/recruitment.test.ts b/src/backend/tests/unit/recruitment.test.ts
@@ -121,7 +121,7 @@ describe('Recruitment Tests', () => {
 
         expect(result.name).toEqual('name');
         expect(result.description).toEqual('description');
-        expect(result.dateOfEvent).toEqual(new Date('11/12/24'));
+        expect(result.dateOfEvent).toEqual(new Date('2024-11-12'));
       });
     });
 
@@ -202,7 +202,7 @@ describe('Recruitment Tests', () => {
 
         expect(updatedMilestone.name).toEqual('new name');
         expect(updatedMilestone.description).toEqual('new description');
-        expect(updatedMilestone.dateOfEvent).toEqual(new Date('11/14/24'));
+        expect(updatedMilestone.dateOfEvent).toEqual(new Date('2024-11-14'));
       });
     });
 
diff --git a/src/backend/tests/unit/reimbursement-requests.test.ts b/src/backend/tests/unit/reimbursement-requests.test.ts
@@ -182,7 +182,7 @@ describe('Reimbursement Requests', () => {
       expect(rr.indexCode.name).toEqual('CASH');
       expect(rr.vendor.vendorId).toEqual(createdVendor.vendorId);
       expect(rr.recipient.userId).toEqual(createdUser.userId);
-      expect(rr.dateOfExpense).toEqual(new Date('12-29-2023'));
+      expect(rr.dateOfExpense).toEqual(new Date('2023-12-29'));
       expect(rr.reimbursementProducts).toHaveLength(1);
       expect(rr.reimbursementProducts[0].name).toEqual('GLUE');
       expect(rr.reimbursementProducts[0].cost).toEqual(200000);
@@ -267,7 +267,11 @@ describe('Reimbursement Requests', () => {
         dateToSetAsDelivered
       );
 
-      expect(updatedRR.dateDelivered).toEqual(dateToSetAsDelivered);
+      // @db.Date strips time component, so compare date portion only
+      const expectedDate = new Date(
+        Date.UTC(dateToSetAsDelivered.getFullYear(), dateToSetAsDelivered.getMonth(), dateToSetAsDelivered.getDate())
+      );
+      expect(updatedRR.dateDelivered).toEqual(expectedDate);
     });
   });
 
diff --git a/src/backend/tests/unmocked/recruitment.test.ts b/src/backend/tests/unmocked/recruitment.test.ts
@@ -121,7 +121,7 @@ describe('Recruitment Tests', () => {
 
         expect(result.name).toEqual('name');
         expect(result.description).toEqual('description');
-        expect(result.dateOfEvent).toEqual(new Date('11/12/24'));
+        expect(result.dateOfEvent).toEqual(new Date('2024-11-12'));
       });
     });
 
@@ -202,7 +202,7 @@ describe('Recruitment Tests', () => {
 
         expect(updatedMilestone.name).toEqual('new name');
         expect(updatedMilestone.description).toEqual('new description');
-        expect(updatedMilestone.dateOfEvent).toEqual(new Date('11/14/24'));
+        expect(updatedMilestone.dateOfEvent).toEqual(new Date('2024-11-14'));
       });
     });
 
diff --git a/src/backend/tests/unmocked/reimbursement-requests.test.ts b/src/backend/tests/unmocked/reimbursement-requests.test.ts
@@ -193,7 +193,7 @@ describe('Reimbursement Requests', () => {
       expect(rr.indexCode.name).toEqual('CASH');
       expect(rr.vendor.vendorId).toEqual(createdVendor.vendorId);
       expect(rr.recipient.userId).toEqual(createdUser.userId);
-      expect(rr.dateOfExpense).toEqual(new Date('12-29-2023'));
+      expect(rr.dateOfExpense).toEqual(new Date('2023-12-29'));
       expect(rr.reimbursementProducts).toHaveLength(1);
       expect(rr.reimbursementProducts[0].name).toEqual('GLUE');
       expect(rr.reimbursementProducts[0].cost).toEqual(200000);
@@ -274,7 +274,11 @@ describe('Reimbursement Requests', () => {
         dateToSetAsDelivered
       );
 
-      expect(updatedRR.dateDelivered).toEqual(dateToSetAsDelivered);
+      // @db.Date strips time component, so compare date portion only
+      const expectedDate = new Date(
+        Date.UTC(dateToSetAsDelivered.getFullYear(), dateToSetAsDelivered.getMonth(), dateToSetAsDelivered.getDate())
+      );
+      expect(updatedRR.dateDelivered).toEqual(expectedDate);
     });
   });
 
diff --git a/src/backend/tests/unmocked/statistics.test.ts b/src/backend/tests/unmocked/statistics.test.ts
@@ -152,8 +152,9 @@ describe('Statistics Tests', () => {
         graphDisplayType: 'PIE',
         measure: Measure.AVG
       });
-      expect(result.startDate).toStrictEqual(new Date('12/12/1970'));
-      expect(result.endDate?.getTime()).toBeGreaterThan(new Date('12/12/2024').getTime());
+      expect(result.startDate).toStrictEqual(new Date('1970-12-12'));
+      // @db.Date stores only date portion, so endDate becomes 2024-12-12 midnight UTC
+      expect(result.endDate).toStrictEqual(new Date('2024-12-12'));
 
       expect(result.graphData).toStrictEqual([
         {
@@ -194,7 +195,7 @@ describe('Statistics Tests', () => {
         graphDisplayType: 'BAR',
         measure: Measure.SUM
       });
-      expect(result.startDate).toStrictEqual(new Date('12/12/1970'));
+      expect(result.startDate).toStrictEqual(new Date('1970-12-12'));
       expect(result.endDate?.getTime()).toBeGreaterThan(new Date('12/12/2024').getTime());
 
       expect(result.graphData).toStrictEqual([
@@ -276,8 +277,8 @@ describe('Statistics Tests', () => {
         graphDisplayType: 'BAR',
         measure: Measure.SUM
       });
-      expect(result.startDate).toStrictEqual(new Date('12/12/1970'));
-      expect(result.endDate).toStrictEqual(new Date('12/12/1971'));
+      expect(result.startDate).toStrictEqual(new Date('1970-12-12'));
+      expect(result.endDate).toStrictEqual(new Date('1971-12-12'));
 
       expect(result.graphData).toStrictEqual([
         {
@@ -459,8 +460,8 @@ describe('Statistics Tests', () => {
 
   describe('Edit Graph', () => {
     it('Edit graph correctly updates startDate, endDate, title, and graphType', async () => {
-      const updatedStartDate = new Date('12/13/2024');
-      const updatedEndDate = new Date(updatedStartDate.getTime() + 10000);
+      const updatedStartDate = new Date('2024-12-13');
+      const updatedEndDate = new Date('2024-12-14');
       const updatedTitle = 'Updated Graph';
       const updatedGraphType = Graph_Type.PROJECT_BUDGET_BY_PROJECT;
       const updatedMeasure = Measure.AVG;
diff --git a/src/frontend/src/pages/CalendarPage/AvailabilityScheduleView.tsx b/src/frontend/src/pages/CalendarPage/AvailabilityScheduleView.tsx
@@ -1,5 +1,5 @@
 import { Table, TableBody, TableCell, TableContainer, TableHead, TableRow, Typography } from '@mui/material';
-import { Availability, Event, EventWithMembers, getDayOfWeek, getNextSevenDays, User } from 'shared';
+import { Availability, dbDateToLocalDate, Event, EventWithMembers, getDayOfWeek, getNextSevenDays, User } from 'shared';
 import React, { useState } from 'react';
 import { enumToArray, getBackgroundColor, NUMBER_OF_TIME_SLOTS, REVIEW_TIMES } from '../../utils/design-review.utils';
 import { datePipe } from '../../utils/pipes';
@@ -30,8 +30,10 @@ const AvailabilityScheduleView: React.FC<AvailabilityScheduleViewProps> = ({
 }) => {
   const totalUsers = usersToAvailabilities.size;
   const [selectedTimeslot, setSelectedTimeslot] = useState<number | null>(null);
-  // Use displayDate if provided, otherwise fall back to event's initial date
-  const initialDate = displayDate || event.initialDateScheduled || new Date();
+  // Use displayDate if provided, otherwise fall back to event's initial date.
+  // initialDateScheduled is @db.Date (midnight UTC) — normalize to local calendar date.
+  const initialDate =
+    displayDate || (event.initialDateScheduled ? dbDateToLocalDate(event.initialDateScheduled) : new Date());
   const potentialDays = getNextSevenDays(initialDate);
 
   // Handle hover - updates the sidebar with available/unavailable users and slot info
diff --git a/src/frontend/src/pages/CalendarPage/CalendarPage.tsx b/src/frontend/src/pages/CalendarPage/CalendarPage.tsx
@@ -666,26 +666,12 @@ const NewCalendarPage: React.FC<NewCalendarPageProps> = ({
                               <CalendarDayCard
                                 cardDate={cardDate}
                                 displayMonth={displayMonthYear}
-                                events={
-                                  showEvents
-                                    ? (eventDict.get(
-                                        datePipe(cardDate)
-                                      ) ?? [])
-                                    : []
-                                }
+                                events={showEvents ? (eventDict.get(datePipe(cardDate)) ?? []) : []}
                                 eventTypes={allEventTypes ?? []}
                                 calendars={allCalendars ?? []}
-                                dayOfWeek={
-                                  dayDict.get(
-                                    datePipe(cardDate)
-                                  ) ?? DayOfWeek.SUNDAY
-                                }
+                                dayOfWeek={dayDict.get(datePipe(cardDate)) ?? DayOfWeek.SUNDAY}
                                 onCreateEventClick={onCreateEventClick}
-                                tasks={
-                                  taskDict.get(
-                                    datePipe(cardDate)
-                                  ) ?? []
-                                }
+                                tasks={taskDict.get(datePipe(cardDate)) ?? []}
                               />
                             </Box>
                           );
diff --git a/src/frontend/src/pages/CalendarPage/CalendarWeekView.tsx b/src/frontend/src/pages/CalendarPage/CalendarWeekView.tsx
@@ -203,11 +203,21 @@ const CalendarWeekView: React.FC<CalendarWeekViewProps> = ({
   );
 
   // Build per-day all-day event lists
+  // Unscheduled design reviews have startTime from @db.Date (midnight UTC) — use UTC comparison.
+  // Scheduled all-day events use local time range comparison for multi-day spans.
   const allDayEventsByDay: EventInstance[][] = weekDays.map((day) =>
     allDayEvents.filter((e) => {
       const start = new Date(e.startTime);
       const end = new Date(e.endTime);
-      // Normalize end to compare day boundaries
+      if (start.getTime() === end.getTime()) {
+        // Single-point event (e.g., unscheduled design review from @db.Date) — compare UTC date
+        return (
+          start.getUTCFullYear() === day.getFullYear() &&
+          start.getUTCMonth() === day.getMonth() &&
+          start.getUTCDate() === day.getDate()
+        );
+      }
+      // Multi-day range — use local time boundary comparison
       const dayStart = new Date(day);
       const dayEnd = new Date(day);
       dayEnd.setDate(dayEnd.getDate() + 1);
@@ -216,10 +226,15 @@ const CalendarWeekView: React.FC<CalendarWeekViewProps> = ({
   );
 
   // Build per-day task lists (tasks appear on their deadline day)
+  // Task deadlines are date-only values (@db.Date, midnight UTC).
+  // Extract UTC components from deadline, local components from weekDay, and compare.
   const tasksByDay: CalendarTask[][] = weekDays.map((day) =>
     tasks.filter((t) => {
       if (!t.deadline) return false;
-      return isSameDay(new Date(t.deadline), day);
+      const d = new Date(t.deadline);
+      return (
+        d.getUTCFullYear() === day.getFullYear() && d.getUTCMonth() === day.getMonth() && d.getUTCDate() === day.getDate()
+      );
     })
   );
 
diff --git a/src/frontend/src/pages/CalendarPage/Components/EventAvailabilityPage.tsx b/src/frontend/src/pages/CalendarPage/Components/EventAvailabilityPage.tsx
@@ -8,6 +8,7 @@ import { useQuery as useQueryParam } from '../../../hooks/utils.hooks';
 import { Box, Grid, Typography, useTheme } from '@mui/material';
 import {
   Availability,
+  dbDateToLocalDate,
   getMostRecentAvailabilities,
   User,
   UserWithScheduleSettings,
@@ -128,7 +129,8 @@ export const EventAvailabilityPage: React.FC = () => {
     if (dateParam) {
       return new Date(dateParam);
     }
-    return event?.initialDateScheduled ?? new Date();
+    // initialDateScheduled is @db.Date (midnight UTC) — normalize to local calendar date
+    return event?.initialDateScheduled ? dbDateToLocalDate(event.initialDateScheduled) : new Date();
   }, [dateParam, event]);
 
   const isUserMember = useMemo(() => {
diff --git a/src/frontend/src/pages/CalendarPage/EventClickPopup.tsx b/src/frontend/src/pages/CalendarPage/EventClickPopup.tsx
@@ -1,6 +1,16 @@
 import React, { useState } from 'react';
 import { Alert, Box, Button, IconButton, Link, Popover, Stack, Typography, useTheme } from '@mui/material';
-import { Calendar, DayOfWeek, EventInstance, EventStatus, EventType, formatEventTime, isAdmin, isHead, wbsPipe } from 'shared';
+import {
+  Calendar,
+  DayOfWeek,
+  EventInstance,
+  EventStatus,
+  EventType,
+  formatEventTime,
+  isAdmin,
+  isHead,
+  wbsPipe
+} from 'shared';
 import { useCurrentUser } from '../../hooks/users.hooks';
 import { Link as RouterLink } from 'react-router-dom';
 import { routes } from '../../utils/routes';
diff --git a/src/frontend/src/pages/CalendarPage/TaskClickPopup.tsx b/src/frontend/src/pages/CalendarPage/TaskClickPopup.tsx
@@ -190,8 +190,7 @@ export const TaskClickContent: React.FC<TaskClickContentProps> = ({ task, onClos
             <Stack direction="row" spacing={1.25} alignItems="center">
               <EventIcon fontSize="small" />
               <Typography variant="body2">
-                <b>Deadline:</b>{' '}
-                {formatDateOnly(new Date(task.deadline), 'MMM D, YYYY')}
+                <b>Deadline:</b> {formatDateOnly(new Date(task.deadline), 'MMM D, YYYY')}
               </Typography>
             </Stack>
           )}
diff --git a/src/frontend/src/pages/GanttPage/GanttChart/GanttChartComponents/GanttTaskBar/GanttTaskBar.tsx b/src/frontend/src/pages/GanttPage/GanttChart/GanttChartComponents/GanttTaskBar/GanttTaskBar.tsx
@@ -45,15 +45,15 @@ const GanttTaskBar = <T,>({
   highlightTaskComparator
 }: GanttTaskBarProps<T>) => {
   const getStartCol = (start: Date) => {
-    const startCol = days.findIndex((day) => toDateString(day) === toDateString(getMonday(start))) + 1;
+    const startCol = days.findIndex((day) => toDateString(day) === toDateString(getMonday(start, true))) + 1;
     return startCol;
   };
 
   const getEndCol = (end: Date) => {
     const endCol =
-      days.findIndex((day) => toDateString(day) === toDateString(getMonday(end))) === -1
+      days.findIndex((day) => toDateString(day) === toDateString(getMonday(end, true))) === -1
         ? days.length + 1
-        : days.findIndex((day) => toDateString(day) === toDateString(getMonday(end))) + 2;
+        : days.findIndex((day) => toDateString(day) === toDateString(getMonday(end, true))) + 2;
     return endCol;
   };
 
diff --git a/src/frontend/src/pages/HomePage/components/EventCard.tsx b/src/frontend/src/pages/HomePage/components/EventCard.tsx
@@ -1,6 +1,6 @@
 import { Box, Card, CardContent, Link, Stack, Typography, useTheme } from '@mui/material';
 import { AuthenticatedUser, Event } from 'shared';
-import { datePipe, meetingStartTimePipeScheduleSlot, projectWbsPipe } from '../../../utils/pipes';
+import { meetingStartTimePipeScheduleSlot, projectWbsPipe } from '../../../utils/pipes';
 import { routes } from '../../../utils/routes';
 import { Link as RouterLink } from 'react-router-dom';
 import CalendarMonthIcon from '@mui/icons-material/CalendarMonth';
@@ -58,15 +58,14 @@ const DisplayStatus: React.FC<EventProps> = ({ event, user }) => {
   );
 };
 
-const getWeekday = (date: Date): string => {
+const getWeekday = (date: Date, utc = false): string => {
+  if (utc) {
+    return formatDateOnly(date, 'dddd');
+  }
   const weekdays: string[] = ['Sunday', 'Monday', 'Tuesday', 'Wednesday', 'Thursday', 'Friday', 'Saturday'];
   return weekdays[date.getDay()];
 };
 
-const removeYear = (str: string): string => {
-  return str.substring(0, str.length - 5);
-};
-
 const UpcomingEventCard: React.FC<EventProps> = ({ event, user }) => {
   const theme = useTheme();
   const firstScheduledDate = event.initialDateScheduled || event.scheduledTimes[0]?.startTime;
@@ -111,7 +110,7 @@ const UpcomingEventCard: React.FC<EventProps> = ({ event, user }) => {
             <Stack direction="row" spacing={1} sx={{ mt: 0.5 }}>
               <Typography>{<CalendarMonthIcon sx={{ fontSize: 21 }} />}</Typography>
               <Typography fontWeight={'regular'} variant="body2">
-                {getWeekday(displayDate) +
+                {getWeekday(displayDate, isDateOnly) +
                   ', ' +
                   formattedDate +
                   ' @ ' +
diff --git a/src/frontend/src/utils/datetime.utils.ts b/src/frontend/src/utils/datetime.utils.ts
diff --git a/src/frontend/src/utils/pipes.ts b/src/frontend/src/utils/pipes.ts
diff --git a/src/shared/src/backend-supports/projects-get-all.ts b/src/shared/src/backend-supports/projects-get-all.ts
diff --git a/src/shared/src/date-format.ts b/src/shared/src/date-format.ts
