Merge pull request #3732 from Northeastern-Electric-Racing/3731-maintenence---link-types-cannot-be-edited

#3731 link type edit works

Author: chpy04

src/backend/src/controllers/projects.controllers.ts

@@ -437,13 +437,14 @@ export default class ProjectsController {
   static async editLinkType(req: Request, res: Response, next: NextFunction) {
     try {
       const { linkTypeName } = req.params;
-      const { iconName, required } = req.body;
+      const { name: newName, iconName, required } = req.body;
       const linkTypeUpdated = await ProjectsService.editLinkType(
         linkTypeName,
         iconName,
         required,
         req.currentUser,
-        req.organization
+        req.organization,
+        newName
       );
       res.status(200).json(linkTypeUpdated);
     } catch (error: unknown) {

src/backend/src/routes/projects.routes.ts

@@ -29,6 +29,7 @@ projectRouter.post(
 );
 projectRouter.post(
   '/link-types/:linkTypeName/edit',
+  nonEmptyString(body('name').optional()),
   nonEmptyString(body('iconName')),
   body('required').isBoolean(),
   validateInputs,

src/backend/src/services/projects.services.ts

@@ -621,7 +621,8 @@ export default class ProjectsService {
     iconName: string,
     required: boolean,
     submitter: User,
-    organization: Organization
+    organization: Organization,
+    newName?: string
   ): Promise<LinkType> {
     if (!(await userHasPermission(submitter.userId, organization.organizationId, isAdmin)))
       throw new AccessDeniedException('Only an admin can update the linkType');
@@ -638,11 +639,25 @@ export default class ProjectsService {
 
     if (!linkType) throw new NotFoundException('Link Type', linkName);
 
+    // If attempting to rename, ensure new name does not conflict with an existing LinkType
+    if (newName && newName !== linkName) {
+      const existingWithNewName = await prisma.link_Type.findUnique({
+        where: {
+          uniqueLinkType: {
+            name: newName,
+            organizationId: organization.organizationId
+          }
+        }
+      });
+
+      if (existingWithNewName) throw new HttpException(400, 'LinkType with that name already exists in this organization.');
+    }
+
     // update the LinkType
     const linkTypeUpdated = await prisma.link_Type.update({
       where: { id: linkType.id },
       data: {
-        name: linkName,
+        name: newName && newName ? newName : linkName,
         iconName,
         required
       }

src/frontend/src/pages/AdminToolsPage/ProjectsConfig/LinkTypes/LinkTypeFormModal.tsx

@@ -63,6 +63,7 @@ const LinkTypeFormModal = ({ open, handleClose, defaultValues, onSubmit, linkTyp
     }
     handleClose();
   };
+
   const tooltipMessage = (
     <Typography sx={{ fontSize: 14 }}>
       Click to view possible icon names. For names with multiple words, seperate them with an _. AttachMoney = attach_money
@@ -73,7 +74,7 @@ const LinkTypeFormModal = ({ open, handleClose, defaultValues, onSubmit, linkTyp
       open={open}
       onHide={handleClose}
       title={!!defaultValues ? 'Edit LinkType' : 'Create LinkType'}
-      reset={() => reset({ name: '' })}
+      reset={reset}
       handleUseFormSubmit={handleSubmit}
       onFormSubmit={onFormSubmit}
       formId={!!defaultValues ? 'edit-LinkType-form' : 'create-LinkType-form'}
@@ -83,7 +84,7 @@ const LinkTypeFormModal = ({ open, handleClose, defaultValues, onSubmit, linkTyp
         <Grid item xs={6}>
           <FormControl fullWidth>
             <FormLabel>LinkType Name</FormLabel>
-            <ReactHookTextField name="name" control={control} disabled={!creatingNew} />
+            <ReactHookTextField name="name" control={control} />
             <FormHelperText error>{errors.name?.message}</FormHelperText>
           </FormControl>
         </Grid>

src/frontend/src/pages/SettingsPage/UserScheduleSettings/UserScheduleSettingsView.tsx

@@ -57,13 +57,13 @@ const UserScheduleSettingsView = ({
   return (
     <Grid container rowSpacing={1} columnSpacing={4}>
       <SingleAvailabilityModal
-        open={availabilityOpen}
+        open={confirmAvailabilityOpen}
         onHide={() => setAvailabilityOpen(false)}
         header={'Availability'}
         availabilites={scheduleSettings.availabilities}
       />
       <AvailabilityEditModal
-        open={confirmAvailabilityOpen}
+        open={availabilityOpen}
         onHide={() => setConfirmAvailabilityOpen(false)}
         header={confirmModalTitle}
         confirmedAvailabilities={confirmedAvailabilities}