#3731 minor fixes

Author: superhvarn

src/backend/src/controllers/projects.controllers.ts

@@ -440,11 +440,11 @@ export default class ProjectsController {
       const { name: newName, iconName, required } = req.body;
       const linkTypeUpdated = await ProjectsService.editLinkType(
         linkTypeName,
-        newName,
         iconName,
         required,
         req.currentUser,
-        req.organization
+        req.organization,
+        newName
       );
       res.status(200).json(linkTypeUpdated);
     } catch (error: unknown) {

src/backend/src/services/projects.services.ts

@@ -618,11 +618,11 @@ export default class ProjectsService {
    */
   static async editLinkType(
     linkName: string,
-    newName: string | undefined,
     iconName: string,
     required: boolean,
     submitter: User,
-    organization: Organization
+    organization: Organization,
+    newName?: string
   ): Promise<LinkType> {
     if (!(await userHasPermission(submitter.userId, organization.organizationId, isAdmin)))
       throw new AccessDeniedException('Only an admin can update the linkType');
@@ -657,7 +657,7 @@ export default class ProjectsService {
     const linkTypeUpdated = await prisma.link_Type.update({
       where: { id: linkType.id },
       data: {
-        name: newName && newName.length > 0 ? newName : linkName,
+        name: newName && newName ? newName : linkName,
         iconName,
         required
       }

src/frontend/src/pages/SettingsPage/UserScheduleSettings/UserScheduleSettingsView.tsx

@@ -57,13 +57,13 @@ const UserScheduleSettingsView = ({
   return (
     <Grid container rowSpacing={1} columnSpacing={4}>
       <SingleAvailabilityModal
-        open={availabilityOpen}
+        open={confirmAvailabilityOpen}
         onHide={() => setAvailabilityOpen(false)}
         header={'Availability'}
         availabilites={scheduleSettings.availabilities}
       />
       <AvailabilityEditModal
-        open={confirmAvailabilityOpen}
+        open={availabilityOpen}
         onHide={() => setConfirmAvailabilityOpen(false)}
         header={confirmModalTitle}
         confirmedAvailabilities={confirmedAvailabilities}