Reject undeclared editor RPC request fields - #1860
Merged
Noisemaker111 merged 2 commits intoSep 27, 2026
Merged
Conversation
set_marker {"catalogId":"raider"} returned ok and saved nothing because the
verb ignored a field it did not declare. The decoder now rejects any
top-level field outside the method's field spec, for every method.
Recovered from the stranded quest worktrees
reject-undeclared-fields-on-every-editor-rpc-verb-s7vbgb (commit 3fbe0bc).
Closes #1838
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Noisemaker111
enabled auto-merge
September 27, 2026 04:06
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Noisemaker111
deleted the
claude/reject-undeclared-rpc-fields-k4w9p2
branch
September 29, 2026 22:34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recovered from the stranded quest worktrees
reject-undeclared-fields-on-every-editor-rpc-verb-s7vbgb,verify-real-rpc-behavior-and-local-gates-ndfcd8andprepare-issue-closing-pr-l996el(all held commit 3fbe0bc, never pushed).decodeEditorBridgeRequestrejects any top-level field outside the method's field spec, for every method, withunknown field "<name>" for method "<verb>".patch,values) stay open.Root cause: the decoder only type-checked declared fields and ignored the rest, so a misspelt or unsupported field returned
ok: trueand saved nothing.Limitation: the MCP stdio path builds requests per tool in
toolToBridge, which still drops unknown tool arguments before the decoder sees them.Closes #1838
Verification
bun --cwd=packages/editor run test: 256 pass, 0 failbun --cwd=packages/editor run check-types: passbun run ship:preflight: okbun run check-changelog(release notechanges/reject-undeclared-rpc-fields-k4w9p2.md): okbun run check-skill-apiaftergen:skill-api: okcli.test.tsbulk import; passes locally and on the first run)--rpc '{"method":"set_marker","id":"x","catalogId":"raider","bogus":1}'→ok:false, $.bogus unknown field "bogus" for method "set_marker";scene_summarywithextra→ rejected; plainscene_summary→ ok🤖 Generated with Claude Code