Skip to content

fix(fetchZyfiSponsored): enhance error handling and logging #118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Douglasacost wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(fetchZyfiSponsored): enhance error handling and logging #118

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions clk-gateway/src/helpers.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,10 +205,15 @@ export async function fetchZyfiSponsored(
body: JSON.stringify(request),
});

const responseBody = await response.json();
if (!response.ok) {
throw new Error(`Failed to fetch zyfi sponsored`);
console.error(
`Failed to fetch zyfi sponsored: ${response.statusText}`,
responseBody,
);
throw new Error(`Failed to fetch zyfi sponsored: ${responseBody.message}`);
}
const sponsoredResponse = (await response.json()) as ZyfiSponsoredResponse;
const sponsoredResponse = responseBody as ZyfiSponsoredResponse;

return sponsoredResponse;
}
Expand Down
12 changes: 10 additions & 2 deletions clk-gateway/src/routes/names.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,8 +126,11 @@ router.post(
let response;
if (zyfiSponsoredUrl) {
const zyfiRequest = buildZyfiRegisterRequest(owner, name, sub);
console.log(`ZyFi request [register]: ${JSON.stringify(zyfiRequest)}`);
const zyfiResponse = await fetchZyfiSponsored(zyfiRequest);
console.log(`ZyFi response: ${JSON.stringify(zyfiResponse)}`);
console.log(
`ZyFi sponsored response [register]: ${JSON.stringify(zyfiResponse)}`,
);

// await admin.auth().revokeRefreshTokens(decodedToken.uid);

Expand Down Expand Up @@ -268,8 +271,13 @@ router.post(
data.key,
data.value,
);
console.log(
`ZyFi request [set-text-record]: ${JSON.stringify(zyfiRequest)}`,
);
const zyfiResponse = await fetchZyfiSponsored(zyfiRequest);
console.log(`ZyFi response: ${JSON.stringify(zyfiResponse)}`);
console.log(
`ZyFi sponsored response [set-text-record]: ${JSON.stringify(zyfiResponse)}`,
);

response = await l2Wallet.sendTransaction(zyfiResponse.txData);
} else {
Expand Down
Loading