feat(vis-network): use scanner extractors - #598
Merged
fraxken merged 1 commit intoJan 5, 2026
Conversation
ErwanRaulo
marked this pull request as draft
November 10, 2025 11:30
ErwanRaulo
force-pushed
the
feat/refactor-extract-dataset
branch
3 times, most recently
from
November 11, 2025 15:41
91f81ef to
33c58a1
Compare
ErwanRaulo
force-pushed
the
feat/refactor-extract-dataset
branch
2 times, most recently
from
December 3, 2025 23:04
b55b601 to
3ce4720
Compare
clemgbld
requested review from
PierreDemailly,
clemgbld and
fraxken
and removed request for
fraxken
December 4, 2025 09:56
ErwanRaulo
force-pushed
the
feat/refactor-extract-dataset
branch
from
December 7, 2025 20:46
3ce4720 to
a336a5e
Compare
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## master #598 +/- ##
============================================
- Coverage 100.00% 56.47% -43.53%
============================================
Files 15 43 +28
Lines 649 3377 +2728
Branches 0 14 +14
============================================
+ Hits 649 1907 +1258
- Misses 0 1470 +1470 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ErwanRaulo
force-pushed
the
feat/refactor-extract-dataset
branch
from
December 15, 2025 20:03
a336a5e to
dde30e3
Compare
clemgbld
reviewed
Dec 15, 2025
ErwanRaulo
force-pushed
the
feat/refactor-extract-dataset
branch
from
January 5, 2026 20:11
dde30e3 to
8217ecd
Compare
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub. |
ErwanRaulo
force-pushed
the
feat/refactor-extract-dataset
branch
2 times, most recently
from
January 5, 2026 21:52
5ad40ac to
cfd90ac
Compare
ErwanRaulo
marked this pull request as ready for review
January 5, 2026 21:53
ErwanRaulo
force-pushed
the
feat/refactor-extract-dataset
branch
from
January 5, 2026 22:26
cfd90ac to
0a41997
Compare
fraxken
approved these changes
Jan 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GOAL
use scanner extractors to get manifest info to show in UI instead of computing scanner results again.
Relates to
NodeSecure/scanner#307
To do / Propositions
improve scanner warnings extractor:
add parameter to filter unwanted warnings
improve scanner contacts extractor:
add publishers to the list ?
current issues / need advices
get node built in to work on browser platform: