Repository navigation
Conversation
An Unsloth install whose experts all stay in RAM lost STRATA_ROUTE_TAIL_SKIP=0 on an AMD card with a tuning table, and the skip costs these files KL (docs/QUANTS.md, The route tail skip). test_setup_unsloth installs the HIP path with a table and checks both entries stay.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem and result
On an AMD card with a hipBLASLt tuning table,
setup.pyreplaced the config's wholeenvwith{"STRATA_HIPBLASLT_TUNING": ...}. An Unsloth install whose experts all stay in RAM (no--resident-budget-gib) lostSTRATA_ROUTE_TAIL_SKIP=0, and the route tail skip costs these files KL (docs/QUANTS.md, "The route tail skip"). After the fix the table joins the existing env and both entries stay.Related discussion
none
Approach
cfg.setdefault("env", {})["STRATA_HIPBLASLT_TUNING"] = str(table), so the table joins the existing env instead of replacing it. Only the non-Control HIP path is changed; the Control path is untouched.Validation
Passed:
test_hip_keeps_the_env_of_an_all_ram_installintools/test_setup_unsloth.py: installs the HIP path with a tuning table and checks that bothSTRATA_HIPBLASLT_TUNINGandSTRATA_ROUTE_TAIL_SKIPare present.Failed:
Not run:
Limits
Only the non-Control HIP path is changed; the Control path is untouched.