Skip to content

[Other] setup: the hipBLASLt table joins the config env instead of replacing it - #4793

Open
sdroege wants to merge 1 commit into
Niko1221:mainfrom
sdroege:fix-setup-hipblaslt-env
Open

sdroege wants to merge 1 commit into
Niko1221:mainfrom
sdroege:fix-setup-hipblaslt-env

Conversation

@sdroege

@sdroege sdroege commented Oct 31, 2026

Copy link
Copy Markdown

Problem and result

On an AMD card with a hipBLASLt tuning table, setup.py replaced the config's whole env with {"STRATA_HIPBLASLT_TUNING": ...}. An Unsloth install whose experts all stay in RAM (no --resident-budget-gib) lost STRATA_ROUTE_TAIL_SKIP=0, and the route tail skip costs these files KL (docs/QUANTS.md, "The route tail skip"). After the fix the table joins the existing env and both entries stay.

Related discussion

none

Approach

cfg.setdefault("env", {})["STRATA_HIPBLASLT_TUNING"] = str(table), so the table joins the existing env instead of replacing it. Only the non-Control HIP path is changed; the Control path is untouched.

Validation

Passed:

  • New test test_hip_keeps_the_env_of_an_all_ram_install in tools/test_setup_unsloth.py: installs the HIP path with a tuning table and checks that both STRATA_HIPBLASLT_TUNING and STRATA_ROUTE_TAIL_SKIP are present.

Failed:

  • none observed

Not run:

  • The full suite on hardware; the test mocks the GPU.

Limits

Only the non-Control HIP path is changed; the Control path is untouched.

An Unsloth install whose experts all stay in RAM lost STRATA_ROUTE_TAIL_SKIP=0 on an AMD card with a tuning table, and the skip costs these files KL (docs/QUANTS.md, The route tail skip). test_setup_unsloth installs the HIP path with a table and checks both entries stay.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant