Logic rewrite#235
Draft
RVSkeLe wants to merge 11 commits into
Draft
Conversation
- TODO: make it per-spawner without EntityLootConfig(?)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
THIS IS A DRAFT. THIS IS NOT PRODUCTION READY.
So, uhm, what started as a small perf fix turned into this thing.
This should bring massive performance improvements, as well as a better memory footprint.
Thanks to ThreadLocalRandom, the generation of random numbers has already improved massively. The whole loot generation logic changed (still changing some things). Before this PR the plugin would generate a List of ItemStack(s) and then add it to a HashMap<Integer, ItemStack>, which caused massive amounts of RAM being used, and very heavy cpu usage.
If this PR proves effective, it will be a significant step towards removing all async operations from the plugin and greatly improving thread safety.