Full UI/UX polish: design tokens, responsive drawer, offline hardening, shortcuts, a11y#4
Merged
Merged
Conversation
Design system (dependency-free): - Restructure app.css into semantic tokens (--surface-*, --status-*, spacing/type/radius/motion scales, focus-ring vars, z-layers); a light theme is now a [data-theme] override block away - Global :focus-visible rings, prefers-reduced-motion support, .sr-only - New ui/ primitives: Icon (inline-SVG set, replaces emoji), Toasts (stacking, severities, sticky errors, undo actions), ConfirmDialog (native <dialog>, promise API, danger mode focuses Cancel), ShortcutsHelp; friendlyWsError() maps protocol codes to sentences Responsive shell: - Sidebar collapses to an overlay drawer at <= 900px (scrim, inert main, focus management, approval-count badge on the hamburger) - Reconnect banner with Retry (reconnectNow with retry-timer tracking) Per-surface polish: - Sidebar: valid button semantics (no nested interactives), per-row busy spinners, delete via confirm dialog, archive with Undo toast, engine/ BYPASS/worktree/needs-approval chips, live-ticking relative time - StatusBar: worktree chip, visible 'starting' status, bypassPermissions now requires confirmation - ChatView: empty-state hint, amber "Stop turn" (red reserved for destructive), jump-to-latest pill - ApprovalCard: Edit/Write render as diffs, Bash as its command, raw JSON collapsed behind a disclosure; Launcher: closable dir browser, surfaced validation errors; LoginGate: explains why you were signed out Offline/error hardening: - ws send() returns success; drafts never cleared on failed sends; Send disabled while offline; approvals cannot be bricked by a dropped socket - Optimistic user bubbles (pendingSends, outside the event log so replay dedupe is untouched) with sending/queued captions; interrupt-dropped queue offers "Restore to composer"; guarded ws JSON parsing Keyboard + a11y: - Global shortcuts (n, /, i, x, Ctrl+B, Alt+arrows, ? help, Esc chain) - aria-labels on all icon-only buttons, live regions for status changes, 28px touch targets on coarse pointers
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Complete UI/UX pass over the web frontend, guided by Nielsen's 10 usability heuristics and Shneiderman's Eight Golden Rules. Dark-only, zero new runtime dependencies. One commit, 26 files, +2,288 / -481.
Design system
app.cssrestructured into semantic tokens (--surface-*,--status-*, spacing/type/radius/motion scales, focus rings, z-layers); a future light theme is a single[data-theme]override block:focus-visiblerings,prefers-reduced-motionsupport,.sr-onlyutilityweb/src/components/ui/primitives:Icon(inline-SVG set, replaces all emoji glyphs),Toasts(stacking, severities, sticky errors, undo actions - removesshowToastprop-drilling),ConfirmDialog(native<dialog>, promise API, danger mode focuses Cancel),ShortcutsHelp,DiffBlockResponsive shell
inertmain, focus management, approval-count badge on the hamburgerPer-surface polish
startingstatus,bypassPermissionsnow requires confirmationOffline / error hardening
ws.ts send()returns success; drafts are never cleared on failed sends; Send disabled while offline; approvals cannot be bricked by a dropped socket; guarded JSON parsingpendingSends, kept outside the event log so replay dedupe is untouched) with "sending…"/"queued" captions; interrupt-dropped queue offers "Restore to composer"Keyboard + a11y
n,/,i,x,Ctrl+B,Alt+↑/↓,?help dialog, contextual Escapearia-labelon every icon-only button, live regions for connection/status changes, 28px touch targets on coarse pointersTest plan
format:check,lint,typecheck,build, server tests (25 passed)